From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Aring Subject: [PATCHv3 net 3/3] net: sched: ife: check on metadata length Date: Thu, 19 Apr 2018 18:14:45 -0400 Message-ID: <20180419221445.26205-4-aring@mojatatu.com> References: <20180419221445.26205-1-aring@mojatatu.com> Cc: jhs@mojatatu.com, davem@davemloft.net, xiyou.wangcong@gmail.com, jiri@resnulli.us, yuvalm@mellanox.com, netdev@vger.kernel.org, kernel@mojatatu.com, Alexander Aring To: yotam.gi@gmail.com Return-path: Received: from mail-io0-f196.google.com ([209.85.223.196]:42989 "EHLO mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753527AbeDSWPP (ORCPT ); Thu, 19 Apr 2018 18:15:15 -0400 Received: by mail-io0-f196.google.com with SMTP id l2-v6so6946515iog.9 for ; Thu, 19 Apr 2018 15:15:14 -0700 (PDT) In-Reply-To: <20180419221445.26205-1-aring@mojatatu.com> Sender: netdev-owner@vger.kernel.org List-ID: This patch checks if sk buffer is available to dererence ife header. If not then NULL will returned to signal an malformed ife packet. This avoids to crashing the kernel from outside. Signed-off-by: Alexander Aring Reviewed-by: Yotam Gigi Acked-by: Jamal Hadi Salim --- net/ife/ife.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/ife/ife.c b/net/ife/ife.c index 7fbe70a0af4b..570a18d4ca32 100644 --- a/net/ife/ife.c +++ b/net/ife/ife.c @@ -70,6 +70,9 @@ void *ife_decode(struct sk_buff *skb, u16 *metalen) u16 ifehdrln; ifehdr = (struct ifeheadr *) (skb->data + skb->dev->hard_header_len); + if (!pskb_may_pull(skb, skb->dev->hard_header_len + IFE_METAHDRLEN)) + return NULL; + ifehdrln = ntohs(ifehdr->metalen); total_pull = skb->dev->hard_header_len + ifehdrln; -- 2.11.0