From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH] net: net_cls: remove a NULL check for css_cls_state
Date: Fri, 20 Apr 2018 10:37:25 -0400 (EDT)
Message-ID: <20180420.103725.37816458687606953.davem@davemloft.net>
References: <1524113961-30166-1-git-send-email-lirongqing@baidu.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org
To: lirongqing@baidu.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:44484 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755000AbeDTOh1 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 20 Apr 2018 10:37:27 -0400
In-Reply-To: <1524113961-30166-1-git-send-email-lirongqing@baidu.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Li RongQing <lirongqing@baidu.com>
Date: Thu, 19 Apr 2018 12:59:21 +0800

> The input of css_cls_state() is impossible to NULL except
> cgrp_css_online, so simplify it
> 
> Signed-off-by: Li RongQing <lirongqing@baidu.com>

I don't view this as an improvement.  Just let the helper always check
NULL and that way there are less situations to audit.

And it's not like this is a critical fast path either.

I'm not applying this, sorry.