From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [Patch net] llc: delete timers synchronously in llc_sk_free() Date: Sun, 22 Apr 2018 14:55:26 -0400 (EDT) Message-ID: <20180422.145526.2100841756239290263.davem@davemloft.net> References: <20180419192538.3362-1-xiyou.wangcong@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: xiyou.wangcong@gmail.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:39944 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753404AbeDVSz2 (ORCPT ); Sun, 22 Apr 2018 14:55:28 -0400 In-Reply-To: <20180419192538.3362-1-xiyou.wangcong@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Cong Wang Date: Thu, 19 Apr 2018 12:25:38 -0700 > The connection timers of an llc sock could be still flying > after we delete them in llc_sk_free(), and even possibly > after we free the sock. We could just wait synchronously > here in case of troubles. > > Note, I leave other call paths as they are, since they may > not have to wait, at least we can change them to synchronously > when needed. > > Also, move the code to net/llc/llc_conn.c, which is apparently > a better place. > > Reported-by: > Signed-off-by: Cong Wang Applied and queued up for -stable.