From: David Miller <davem@davemloft.net>
To: ssuryaextr@gmail.com
Cc: netdev@vger.kernel.org, ja@ssi.bg
Subject: Re: [PATCH net-next, v2] Per interface IPv4 stats (CONFIG_IP_IFSTATS_TABLE)
Date: Mon, 23 Apr 2018 10:07:56 -0400 (EDT) [thread overview]
Message-ID: <20180423.100756.356745580041655992.davem@davemloft.net> (raw)
In-Reply-To: <1524268363-5846-1-git-send-email-ssuryaextr@gmail.com>
From: Stephen Suryaputra <ssuryaextr@gmail.com>
Date: Fri, 20 Apr 2018 19:52:43 -0400
> This is enhanced from the proposed patch by Igor Maravic in 2011 to
> support per interface IPv4 stats. The enhancement is mainly adding a
> kernel configuration option CONFIG_IP_IFSTATS_TABLE.
>
> Changes from v1:
> - Count input statistics in the input device (per Julian Anastasov).
> - Changes so that the existing per interface IPv6 stats aren't affected
> when the option isn't enabled.
> - Restore the order of calling ipv4_proc_init().
>
> Signed-off-by: Stephen Suryaputra <ssuryaextr@gmail.com>
Using a config option to control this is not appropriate.
Every distribution is going to enable this option in their kernels.
If the thinking is that a controversial semantic change can be added
as long as it can be disabled by a kernel config option, then sorry I
have to inform you that is not really how this kind of situation
works.
I'm not applying this patch, sorry.
prev parent reply other threads:[~2018-04-23 14:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-20 23:52 [PATCH net-next, v2] Per interface IPv4 stats (CONFIG_IP_IFSTATS_TABLE) Stephen Suryaputra
2018-04-23 14:07 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180423.100756.356745580041655992.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ja@ssi.bg \
--cc=netdev@vger.kernel.org \
--cc=ssuryaextr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).