From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next, v2] Per interface IPv4 stats
 (CONFIG_IP_IFSTATS_TABLE)
Date: Mon, 23 Apr 2018 10:07:56 -0400 (EDT)
Message-ID: <20180423.100756.356745580041655992.davem@davemloft.net>
References: <1524268363-5846-1-git-send-email-ssuryaextr@gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, ja@ssi.bg
To: ssuryaextr@gmail.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:48860 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755107AbeDWOH5 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 23 Apr 2018 10:07:57 -0400
In-Reply-To: <1524268363-5846-1-git-send-email-ssuryaextr@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Stephen Suryaputra <ssuryaextr@gmail.com>
Date: Fri, 20 Apr 2018 19:52:43 -0400

> This is enhanced from the proposed patch by Igor Maravic in 2011 to
> support per interface IPv4 stats. The enhancement is mainly adding a
> kernel configuration option CONFIG_IP_IFSTATS_TABLE.
> 
> Changes from v1:
> - Count input statistics in the input device (per Julian Anastasov).
> - Changes so that the existing per interface IPv6 stats aren't affected
>   when the option isn't enabled.
> - Restore the order of calling ipv4_proc_init().
> 
> Signed-off-by: Stephen Suryaputra <ssuryaextr@gmail.com>

Using a config option to control this is not appropriate.

Every distribution is going to enable this option in their kernels.

If the thinking is that a controversial semantic change can be added
as long as it can be disabled by a kernel config option, then sorry I
have to inform you that is not really how this kind of situation
works.

I'm not applying this patch, sorry.