From: David Miller <davem@davemloft.net>
To: borisp@mellanox.com
Cc: netdev@vger.kernel.org, saeedm@mellanox.com, davejwatson@fb.com,
ktkhai@virtuozzo.com, ilyal@mellanox.com
Subject: Re: [PATCH V6 net-next 08/15] net/tls: Support TLS device offload with IPv6
Date: Mon, 23 Apr 2018 20:56:06 -0400 (EDT) [thread overview]
Message-ID: <20180423.205606.1357960781269124348.davem@davemloft.net> (raw)
In-Reply-To: <1524410397-108425-9-git-send-email-borisp@mellanox.com>
From: Boris Pismenny <borisp@mellanox.com>
Date: Sun, 22 Apr 2018 18:19:50 +0300
> @@ -97,13 +102,57 @@ static void tls_device_queue_ctx_destruction(struct tls_context *ctx)
> spin_unlock_irqrestore(&tls_device_lock, flags);
> }
>
> +#if IS_ENABLED(CONFIG_IPV6)
> +static struct net_device *ipv6_get_netdev(struct sock *sk)
> +{
> + struct net_device *dev = NULL;
> + struct inet_sock *inet = inet_sk(sk);
> + struct ipv6_pinfo *np = inet6_sk(sk);
> + struct flowi6 _fl6, *fl6 = &_fl6;
> + struct dst_entry *dst;
Ugh, please use sk->sk_dst_cache->dev and avoid all of the unnecessary
work.
Thank you.
next prev parent reply other threads:[~2018-04-24 0:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-22 15:19 [PATCH V6 net-next 00/15] TLS offload, netdev & MLX5 support Boris Pismenny
2018-04-22 15:19 ` [PATCH V6 net-next 01/15] tcp: Add clean acked data hook Boris Pismenny
2018-04-22 15:19 ` [PATCH V6 net-next 02/15] net: Rename and export copy_skb_header Boris Pismenny
2018-04-22 15:19 ` [PATCH V6 net-next 03/15] net: Add Software fallback infrastructure for socket dependent offloads Boris Pismenny
2018-04-22 15:19 ` [PATCH V6 net-next 04/15] net: Add TLS offload netdev ops Boris Pismenny
2018-04-22 15:19 ` [PATCH V6 net-next 05/15] net: Add TLS TX offload features Boris Pismenny
2018-04-22 15:19 ` [PATCH V6 net-next 06/15] net/tls: Split conf to rx + tx Boris Pismenny
2018-04-22 15:19 ` [PATCH V6 net-next 07/15] net/tls: Add generic NIC offload infrastructure Boris Pismenny
2018-04-24 0:55 ` David Miller
2018-04-22 15:19 ` [PATCH V6 net-next 08/15] net/tls: Support TLS device offload with IPv6 Boris Pismenny
2018-04-24 0:56 ` David Miller [this message]
2018-04-22 15:19 ` [PATCH V6 net-next 09/15] net/mlx5e: Move defines out of ipsec code Boris Pismenny
2018-04-22 15:19 ` [PATCH V6 net-next 10/15] net/mlx5: Accel, Add TLS tx offload interface Boris Pismenny
2018-04-22 15:19 ` [PATCH V6 net-next 11/15] net/mlx5e: TLS, Add Innova TLS TX support Boris Pismenny
2018-04-22 15:19 ` [PATCH V6 net-next 12/15] net/mlx5e: TLS, Add Innova TLS TX offload data path Boris Pismenny
2018-04-22 15:19 ` [PATCH V6 net-next 13/15] net/mlx5e: TLS, Add error statistics Boris Pismenny
2018-04-22 15:19 ` [PATCH V6 net-next 14/15] MAINTAINERS: Update mlx5 innova driver maintainers Boris Pismenny
2018-04-22 15:19 ` [PATCH V6 net-next 15/15] MAINTAINERS: Update TLS maintainers Boris Pismenny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180423.205606.1357960781269124348.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=borisp@mellanox.com \
--cc=davejwatson@fb.com \
--cc=ilyal@mellanox.com \
--cc=ktkhai@virtuozzo.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox