From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] net: fib_rules: fix l3mdev netlink attr processing Date: Mon, 23 Apr 2018 23:21:58 -0400 (EDT) Message-ID: <20180423.232158.1633374650832506893.davem@davemloft.net> References: <1524539321-9103-1-git-send-email-roopa@cumulusnetworks.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, dsa@cumulusnetworks.com To: roopa@cumulusnetworks.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:57414 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932776AbeDXDWC (ORCPT ); Mon, 23 Apr 2018 23:22:02 -0400 In-Reply-To: <1524539321-9103-1-git-send-email-roopa@cumulusnetworks.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Roopa Prabhu Date: Mon, 23 Apr 2018 20:08:41 -0700 > From: Roopa Prabhu > > Fixes: b16fb418b1bf ("net: fib_rules: add extack support") > Signed-off-by: Roopa Prabhu Applied. It would be nice to get rid of these if() conditionals dangling around ifdef blocks. They are quite error prone.