From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH v7 net-next 4/4] netvsc: refactor notifier/event handling code to use the failover framework Date: Mon, 23 Apr 2018 20:24:56 +0300 Message-ID: <20180423202204-mutt-send-email-mst@kernel.org> References: <1524188524-28411-1-git-send-email-sridhar.samudrala@intel.com> <1524188524-28411-5-git-send-email-sridhar.samudrala@intel.com> <20180420082802.6ca37e4c@xeon-e3> <20180420160058.GB2150@nanopsycho.orion> <20180423100406.71b95f74@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jiri Pirko , Sridhar Samudrala , davem@davemloft.net, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, virtio-dev@lists.oasis-open.org, jesse.brandeburg@intel.com, alexander.h.duyck@intel.com, kubakici@wp.pl, jasowang@redhat.com, loseweigh@gmail.com To: Stephen Hemminger Return-path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:51918 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932111AbeDWRY6 (ORCPT ); Mon, 23 Apr 2018 13:24:58 -0400 Content-Disposition: inline In-Reply-To: <20180423100406.71b95f74@xeon-e3> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Apr 23, 2018 at 10:04:06AM -0700, Stephen Hemminger wrote: > > > > > >I will NAK patches to change to common code for netvsc especially the > > >three device model. MS worked hard with distro vendors to support transparent > > >mode, ans we really can't have a new model; or do backport. > > > > > >Plus, DPDK is now dependent on existing model. > > > > Sorry, but nobody here cares about dpdk or other similar oddities. > > The network device model is a userspace API, and DPDK is a userspace application. It is userspace but are you sure dpdk is actually poking at netdevs? AFAIK it's normally banging device registers directly. > You can't go breaking userspace even if you don't like the application. Could you please explain how is the proposed patchset breaking userspace? Ignoring DPDK for now, I don't think it changes the userspace API at all. -- MST