From: David Miller <davem@davemloft.net>
To: laoar.shao@gmail.com
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH v2 net-next] Revert "net: init sk_cookie for inet socket"
Date: Tue, 24 Apr 2018 11:10:10 -0400 (EDT) [thread overview]
Message-ID: <20180424.111010.555462525376521518.davem@davemloft.net> (raw)
In-Reply-To: <1524582465-11055-1-git-send-email-laoar.shao@gmail.com>
From: Yafang Shao <laoar.shao@gmail.com>
Date: Tue, 24 Apr 2018 23:07:45 +0800
> This reverts commit <c6849a3ac17e> ("net: init sk_cookie for inet socket")
>
> Per discussion with Eric, when update sock_net(sk)->cookie_gen, the
> whole cache cache line will be invalidated, as this cache line is shared
> with all cpus, that may cause great performace hit.
>
> Bellow is the data form Eric.
> "Performance is reduced from ~5 Mpps to ~3.8 Mpps with 16 RX queues on
> my host" when running synflood test.
>
> Have to revert it to prevent from cache line false sharing.
>
> Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
Applied, thank you.
next prev parent reply other threads:[~2018-04-24 15:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 15:07 [PATCH v2 net-next] Revert "net: init sk_cookie for inet socket" Yafang Shao
2018-04-24 15:10 ` David Miller [this message]
2018-04-24 15:10 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180424.111010.555462525376521518.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=laoar.shao@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).