From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH v2 net-next] Revert "net: init sk_cookie for inet
 socket"
Date: Tue, 24 Apr 2018 11:10:10 -0400 (EDT)
Message-ID: <20180424.111010.555462525376521518.davem@davemloft.net>
References: <1524582465-11055-1-git-send-email-laoar.shao@gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org
To: laoar.shao@gmail.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:35510 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750835AbeDXPKM (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 24 Apr 2018 11:10:12 -0400
In-Reply-To: <1524582465-11055-1-git-send-email-laoar.shao@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Yafang Shao <laoar.shao@gmail.com>
Date: Tue, 24 Apr 2018 23:07:45 +0800

> This reverts commit <c6849a3ac17e> ("net: init sk_cookie for inet socket")
> 
> Per discussion with Eric, when update sock_net(sk)->cookie_gen, the
> whole cache cache line will be invalidated, as this cache line is shared
> with all cpus, that may cause great performace hit.
> 
> Bellow is the data form Eric.
> "Performance is reduced from ~5 Mpps to ~3.8 Mpps with 16 RX queues on
> my host" when running synflood test.
> 
> Have to revert it to prevent from cache line false sharing.
> 
> Signed-off-by: Yafang Shao <laoar.shao@gmail.com>

Applied, thank you.