* [PATCH net v2] net: ethtool: Add missing kernel doc for FEC parameters
@ 2018-04-23 22:51 Florian Fainelli
2018-04-24 4:41 ` Roopa Prabhu
2018-04-24 17:38 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Florian Fainelli @ 2018-04-23 22:51 UTC (permalink / raw)
To: netdev; +Cc: davem, vidya.chowdary, dustin, roopa, Florian Fainelli
While adding support for ethtool::get_fecparam and set_fecparam, kernel
doc for these functions was missed, add those.
Fixes: 1a5f3da20bd9 ("net: ethtool: add support for forward error correction modes")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
Changes in v2:
- corrected set_fecparam in commit message
include/linux/ethtool.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h
index ebe41811ed34..b32cd2062f18 100644
--- a/include/linux/ethtool.h
+++ b/include/linux/ethtool.h
@@ -310,6 +310,8 @@ bool ethtool_convert_link_mode_to_legacy_u32(u32 *legacy_u32,
* fields should be ignored (use %__ETHTOOL_LINK_MODE_MASK_NBITS
* instead of the latter), any change to them will be overwritten
* by kernel. Returns a negative error code or zero.
+ * @get_fecparam: Get the network device Forward Error Correction parameters.
+ * @set_fecparam: Set the network device Forward Error Correction parameters.
*
* All operations are optional (i.e. the function pointer may be set
* to %NULL) and callers must take this into account. Callers must
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net v2] net: ethtool: Add missing kernel doc for FEC parameters
2018-04-23 22:51 [PATCH net v2] net: ethtool: Add missing kernel doc for FEC parameters Florian Fainelli
@ 2018-04-24 4:41 ` Roopa Prabhu
2018-04-24 17:38 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Roopa Prabhu @ 2018-04-24 4:41 UTC (permalink / raw)
To: Florian Fainelli
Cc: netdev, David Miller, Vidya Sagar Ravipati, Dustin Byford
On Mon, Apr 23, 2018 at 3:51 PM, Florian Fainelli <f.fainelli@gmail.com> wrote:
> While adding support for ethtool::get_fecparam and set_fecparam, kernel
> doc for these functions was missed, add those.
>
> Fixes: 1a5f3da20bd9 ("net: ethtool: add support for forward error correction modes")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Thanks Florian.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net v2] net: ethtool: Add missing kernel doc for FEC parameters
2018-04-23 22:51 [PATCH net v2] net: ethtool: Add missing kernel doc for FEC parameters Florian Fainelli
2018-04-24 4:41 ` Roopa Prabhu
@ 2018-04-24 17:38 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-04-24 17:38 UTC (permalink / raw)
To: f.fainelli; +Cc: netdev, vidya.chowdary, dustin, roopa
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Mon, 23 Apr 2018 15:51:38 -0700
> While adding support for ethtool::get_fecparam and set_fecparam, kernel
> doc for these functions was missed, add those.
>
> Fixes: 1a5f3da20bd9 ("net: ethtool: add support for forward error correction modes")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> Changes in v2:
>
> - corrected set_fecparam in commit message
Applied, thanks Florian.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-24 17:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-23 22:51 [PATCH net v2] net: ethtool: Add missing kernel doc for FEC parameters Florian Fainelli
2018-04-24 4:41 ` Roopa Prabhu
2018-04-24 17:38 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).