From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [Cake] [PATCH iproute2-next v3] Add support for cake qdisc Date: Tue, 24 Apr 2018 08:10:08 -0700 Message-ID: <20180424081008.2ad7eaa7@xeon-e3> References: <20180424114407.5939-2-toke@toke.dk> <20180424123046.21247-1-toke@toke.dk> <20180424074552.397564a5@xeon-e3> <87efj47j1y.fsf@toke.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: netdev@vger.kernel.org, cake@lists.bufferbloat.net To: Toke =?UTF-8?B?SMO4aWxhbmQtSsO4cmdlbnNlbg==?= Return-path: Received: from mail-pf0-f173.google.com ([209.85.192.173]:38025 "EHLO mail-pf0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751047AbeDXPKL (ORCPT ); Tue, 24 Apr 2018 11:10:11 -0400 Received: by mail-pf0-f173.google.com with SMTP id o76so7797910pfi.5 for ; Tue, 24 Apr 2018 08:10:11 -0700 (PDT) In-Reply-To: <87efj47j1y.fsf@toke.dk> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 24 Apr 2018 16:52:57 +0200 Toke H=C3=B8iland-J=C3=B8rgensen wrote: > Well, this is leftover from keeping track of different versions of the > out-of-tree patch, and we already broke compatibility pretty thoroughly > as a preparation for upstreaming. So I'm fine with dropping the version > check; will resend. >=20 > That being said, the versioning comes from the XSTATS API, which does > not use netlink attributes for its members, but rather passes through as > struct. So what is one supposed to do in this case? If a structure is likely to change, then it should be decomposed into nested netlink attributes. Once you send a structure over userspace API in netlink it is fixed forever.