From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [PATCH] net: nfp: fix nfp_net_tx()'s return type Date: Tue, 24 Apr 2018 11:09:21 -0700 Message-ID: <20180424110921.24c3699b@cakuba.netronome.com> References: <20180424131710.4206-1-luc.vanoostenryck@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, "David S. Miller" , Simon Horman , Daniel Borkmann , Dirk van der Merwe , Pablo =?UTF-8?B?Q2FzY8Ozbg==?= , oss-drivers@netronome.com, netdev@vger.kernel.org To: Luc Van Oostenryck Return-path: In-Reply-To: <20180424131710.4206-1-luc.vanoostenryck@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Tue, 24 Apr 2018 15:17:07 +0200, Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. > > Fix this by returning 'netdev_tx_t' in this driver too. > > Signed-off-by: Luc Van Oostenryck Acked-by: Jakub Kicinski