From: Ahmed Abdelsalam <amsalam20@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: dav.lebrun@gmail.com, kuznet@ms2.inr.ac.ru,
yoshfuji@linux-ipv6.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [net-next 1/2] ipv6: sr: add a per namespace sysctl to control seg6 flowlabel
Date: Tue, 24 Apr 2018 19:25:13 +0200 [thread overview]
Message-ID: <20180424192513.113ec48f44792cad25eeffba@gmail.com> (raw)
In-Reply-To: <20180424.131650.2276839479783300009.davem@davemloft.net>
On Tue, 24 Apr 2018 13:16:50 -0400 (EDT)
David Miller <davem@davemloft.net> wrote:
> From: Ahmed Abdelsalam <amsalam20@gmail.com>
> Date: Mon, 23 Apr 2018 23:36:59 +0200
>
> > This patch adds a per namespace sysctl, named 'seg6_flowlabel', to be used
> > by seg6_do_srh_encap() to control the behaviour of setting the flowlabel
> > value of outer IPv6.
> >
> > The currently support behaviours are as follows:
> > -1 set flowlabel to zero.
> > 0 copy flowlabel from Inner paceket in case of Inner IPv6 (0 for IPv4/L2)
> > 1 Compute the flowlabel using seg6_make_flowlabel()
> >
> > Signed-off-by: Ahmed Abdelsalam <amsalam20@gmail.com>
>
> There really isn't a reason to make this a separate patch.
>
> Adding a sysctl that nothing refers to doesn't add much value.
>
> So please combine patches #1 and #2.
Ok, I will combine them and send you a new patch.
Thanks
--
Ahmed Abdelsalam <amsalam20@gmail.com>
prev parent reply other threads:[~2018-04-24 17:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-23 21:36 [net-next 1/2] ipv6: sr: add a per namespace sysctl to control seg6 flowlabel Ahmed Abdelsalam
2018-04-23 21:37 ` [net-next 2/2] ipv6: sr: Compute flowlabel of outer IPv6 header for seg6 encap mode Ahmed Abdelsalam
2018-04-24 10:10 ` kbuild test robot
2018-04-24 10:10 ` [RFC PATCH] ipv6: sr: seg6_make_flowlabel() can be static kbuild test robot
2018-04-24 17:16 ` [net-next 1/2] ipv6: sr: add a per namespace sysctl to control seg6 flowlabel David Miller
2018-04-24 17:25 ` Ahmed Abdelsalam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180424192513.113ec48f44792cad25eeffba@gmail.com \
--to=amsalam20@gmail.com \
--cc=dav.lebrun@gmail.com \
--cc=davem@davemloft.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).