From: Christian Brauner <christian.brauner@canonical.com>
To: David Miller <davem@davemloft.net>
Cc: ebiederm@xmission.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, avagin@virtuozzo.com,
ktkhai@virtuozzo.com, serge@hallyn.com,
gregkh@linuxfoundation.org
Subject: Re: [PATCH net-next 2/2 v1] netns: isolate seqnums to use per-netns locks
Date: Tue, 24 Apr 2018 22:45:59 +0200 [thread overview]
Message-ID: <20180424204558.GA16013@gmail.com> (raw)
In-Reply-To: <20180424.153925.2063217911734444324.davem@davemloft.net>
On Tue, Apr 24, 2018 at 03:39:25PM -0400, David Miller wrote:
> From: Christian Brauner <christian.brauner@ubuntu.com>
> Date: Mon, 23 Apr 2018 12:24:43 +0200
>
> > + #ifdef CONFIG_NET
> > + seqnum = get_ns_uevent_seqnum_by_vpid();
> > + #else
> > + seqnum = uevent_seqnum;
> > + #endif
>
> Please don't indend the code like this.
>
> By indenting the CPP directives, which should be at column zero, the
> actual code became double indented.
Ah, sorry. Sent v2 with the indendation fixed just now.
Thanks!
Christian
prev parent reply other threads:[~2018-04-24 20:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-23 10:24 [PATCH net-next 0/2 v1] netns: uevent performance tweaks Christian Brauner
2018-04-23 10:24 ` [PATCH net-next 1/2 v1] netns: restrict uevents Christian Brauner
2018-04-23 10:24 ` [PATCH net-next 2/2 v1] netns: isolate seqnums to use per-netns locks Christian Brauner
2018-04-24 19:39 ` David Miller
2018-04-24 20:45 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180424204558.GA16013@gmail.com \
--to=christian.brauner@canonical.com \
--cc=avagin@virtuozzo.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).