From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Brauner Subject: Re: [PATCH net-next 2/2 v1] netns: isolate seqnums to use per-netns locks Date: Tue, 24 Apr 2018 22:45:59 +0200 Message-ID: <20180424204558.GA16013@gmail.com> References: <20180423102443.16627-1-christian.brauner@ubuntu.com> <20180423102443.16627-3-christian.brauner@ubuntu.com> <20180424.153925.2063217911734444324.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: ebiederm@xmission.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, avagin@virtuozzo.com, ktkhai@virtuozzo.com, serge@hallyn.com, gregkh@linuxfoundation.org To: David Miller Return-path: Received: from youngberry.canonical.com ([91.189.89.112]:59962 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750779AbeDXUqC (ORCPT ); Tue, 24 Apr 2018 16:46:02 -0400 Received: from mail-wr0-f199.google.com ([209.85.128.199]) by youngberry.canonical.com with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1fB4p7-0000Q4-9K for netdev@vger.kernel.org; Tue, 24 Apr 2018 20:46:01 +0000 Received: by mail-wr0-f199.google.com with SMTP id h1-v6so23391173wre.0 for ; Tue, 24 Apr 2018 13:46:01 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180424.153925.2063217911734444324.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Apr 24, 2018 at 03:39:25PM -0400, David Miller wrote: > From: Christian Brauner > Date: Mon, 23 Apr 2018 12:24:43 +0200 > > > + #ifdef CONFIG_NET > > + seqnum = get_ns_uevent_seqnum_by_vpid(); > > + #else > > + seqnum = uevent_seqnum; > > + #endif > > Please don't indend the code like this. > > By indenting the CPP directives, which should be at column zero, the > actual code became double indented. Ah, sorry. Sent v2 with the indendation fixed just now. Thanks! Christian