From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] net: rules: Move l3mdev attribute validation to a helper Date: Wed, 25 Apr 2018 13:26:34 -0400 (EDT) Message-ID: <20180425.132634.2115452355426000036.davem@davemloft.net> References: <20180425013607.27953-1-dsahern@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: dsahern@gmail.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:52604 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755019AbeDYR0g (ORCPT ); Wed, 25 Apr 2018 13:26:36 -0400 In-Reply-To: <20180425013607.27953-1-dsahern@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: David Ahern Date: Tue, 24 Apr 2018 18:36:07 -0700 > Move the check on FRA_L3MDEV attribute to helper to improve the > readability of fib_nl2rule. Update the extack messages to be > clear when the configuration option is disabled versus an invalid > value has been passed. > > Signed-off-by: David Ahern That looks a lot better. Applied, thanks David.