netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: jakub.kicinski@netronome.com
Cc: netdev@vger.kernel.org, oss-drivers@netronome.com
Subject: Re: [PATCH net-next 0/4] nfp: flower tc block support and nfp PCI updates
Date: Wed, 25 Apr 2018 14:07:34 -0400 (EDT)	[thread overview]
Message-ID: <20180425.140734.1804002553375011392.davem@davemloft.net> (raw)
In-Reply-To: <20180425041704.26882-1-jakub.kicinski@netronome.com>

From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Tue, 24 Apr 2018 21:17:00 -0700

> This series improves the nfp PCIe code by making use of the new
> pcie_print_link_status() helper and resetting NFP locks when
> driver loads.  This can help us avoid lock ups after host crashes
> and is rebooted with PCIe reset or when kdump kernel is loaded.
> 
> The flower changes come from John, he says:
> 
> This patchset fixes offload issues when multiple repr netdevs are bound to
> a tc block and filter rules added. Previously the rule would be passed to
> the reprs and would be rejected in all but the first as the cookie value
> will indicate a duplicate. The first patch extends the flow lookup
> function to consider both host context and ingress netdev along with the
> cookie value. This means that a rule with a given cookie can exist
> multiple times assuming the ingress netdev is different. The host context
> ensures that stats from fw are associated with the correct instance of the
> rule.
> 
> The second patch protects against rejecting add/del/stat messages when a
> rule has a repr as both an ingress port and an egress dev. In such cases a
> callback can be triggered twice (once for ingress and once for egress)
> and can lead to duplicate rule detection or incorrect double calls.

Series applied, thanks Jakub.

      parent reply	other threads:[~2018-04-25 18:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-25  4:17 [PATCH net-next 0/4] nfp: flower tc block support and nfp PCI updates Jakub Kicinski
2018-04-25  4:17 ` [PATCH net-next 1/4] nfp: reset local locks on init Jakub Kicinski
2018-04-25  4:17 ` [PATCH net-next 2/4] nfp: print PCIe link bandwidth on probe Jakub Kicinski
2018-04-25  4:17 ` [PATCH net-next 3/4] nfp: flower: support offloading multiple rules with same cookie Jakub Kicinski
2018-04-25  6:31   ` Or Gerlitz
2018-04-25  8:51     ` John Hurley
2018-04-25  8:56       ` Or Gerlitz
2018-04-25  9:02         ` John Hurley
2018-04-25  9:13           ` Or Gerlitz
2018-04-25  9:27             ` John Hurley
2018-04-25  4:17 ` [PATCH net-next 4/4] nfp: flower: ignore duplicate cb requests for same rule Jakub Kicinski
2018-04-25  9:17   ` Or Gerlitz
2018-04-25  9:45     ` John Hurley
2018-04-25 18:07 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180425.140734.1804002553375011392.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=jakub.kicinski@netronome.com \
    --cc=netdev@vger.kernel.org \
    --cc=oss-drivers@netronome.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).