From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next 0/4] nfp: flower tc block support and nfp PCI updates Date: Wed, 25 Apr 2018 14:07:34 -0400 (EDT) Message-ID: <20180425.140734.1804002553375011392.davem@davemloft.net> References: <20180425041704.26882-1-jakub.kicinski@netronome.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, oss-drivers@netronome.com To: jakub.kicinski@netronome.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:53214 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750935AbeDYSHj (ORCPT ); Wed, 25 Apr 2018 14:07:39 -0400 In-Reply-To: <20180425041704.26882-1-jakub.kicinski@netronome.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Jakub Kicinski Date: Tue, 24 Apr 2018 21:17:00 -0700 > This series improves the nfp PCIe code by making use of the new > pcie_print_link_status() helper and resetting NFP locks when > driver loads. This can help us avoid lock ups after host crashes > and is rebooted with PCIe reset or when kdump kernel is loaded. > > The flower changes come from John, he says: > > This patchset fixes offload issues when multiple repr netdevs are bound to > a tc block and filter rules added. Previously the rule would be passed to > the reprs and would be rejected in all but the first as the cookie value > will indicate a duplicate. The first patch extends the flow lookup > function to consider both host context and ingress netdev along with the > cookie value. This means that a rule with a given cookie can exist > multiple times assuming the ingress netdev is different. The host context > ensures that stats from fw are associated with the correct instance of the > rule. > > The second patch protects against rejecting add/del/stat messages when a > rule has a repr as both an ingress port and an egress dev. In such cases a > callback can be triggered twice (once for ingress and once for egress) > and can lead to duplicate rule detection or incorrect double calls. Series applied, thanks Jakub.