From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesper Dangaard Brouer Subject: Re: [PATCH RFC 2/9] veth: Add driver XDP Date: Wed, 25 Apr 2018 22:39:41 +0200 Message-ID: <20180425223852.0be2fd67@brouer.com> References: <20180424143923.26519-1-toshiaki.makita1@gmail.com> <20180424143923.26519-3-toshiaki.makita1@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: brouer@redhat.com, netdev@vger.kernel.org, Toshiaki Makita To: Toshiaki Makita Return-path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:38598 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751022AbeDYUjo (ORCPT ); Wed, 25 Apr 2018 16:39:44 -0400 In-Reply-To: <20180424143923.26519-3-toshiaki.makita1@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 24 Apr 2018 23:39:16 +0900 Toshiaki Makita wrote: > This is basic implementation of veth driver XDP. > > Incoming packets are sent from the peer veth device in the form of skb, > so this is generally doing the same thing as generic XDP. I'm unsure that context you are calling veth_xdp_rcv_skb() from. The XDP (RX side) depend heavily on the protection provided by NAPI context. It looks like you are adding NAPI handler later. -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer