From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH net-next] bridge: use hlist_entry_safe Date: Thu, 26 Apr 2018 08:54:13 -0700 Message-ID: <20180426085413.53cad9ad@xeon-e3> References: <20180426030705.6632-1-yuehaibing@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: , , To: YueHaibing Return-path: Received: from mail-pg0-f65.google.com ([74.125.83.65]:36468 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756519AbeDZPyQ (ORCPT ); Thu, 26 Apr 2018 11:54:16 -0400 Received: by mail-pg0-f65.google.com with SMTP id i6so16236222pgv.3 for ; Thu, 26 Apr 2018 08:54:16 -0700 (PDT) In-Reply-To: <20180426030705.6632-1-yuehaibing@huawei.com> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, 26 Apr 2018 11:07:05 +0800 YueHaibing wrote: > Use hlist_entry_safe() instead of open-coding it. > > Signed-off-by: YueHaibing > --- > net/bridge/br_forward.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/net/bridge/br_forward.c b/net/bridge/br_forward.c > index b4eed11..7a7fd67 100644 > --- a/net/bridge/br_forward.c > +++ b/net/bridge/br_forward.c > @@ -274,8 +274,7 @@ void br_multicast_flood(struct net_bridge_mdb_entry *mdst, > struct net_bridge_port *port, *lport, *rport; > > lport = p ? p->port : NULL; > - rport = rp ? hlist_entry(rp, struct net_bridge_port, rlist) : > - NULL; > + rport = hlist_entry_safe(rp, struct net_bridge_port, rlist); > > if ((unsigned long)lport > (unsigned long)rport) { > port = lport; Reviewed-by: Stephen Hemminger