From: Jiri Benc <jbenc@redhat.com>
To: John Fastabend <john.fastabend@gmail.com>
Cc: ast@kernel.org, daniel@iogearbox.net, netdev@vger.kernel.org
Subject: Re: [bpf PATCH v2] bpf: fix for lex/yacc build error with gcc-5
Date: Thu, 26 Apr 2018 10:43:17 +0200 [thread overview]
Message-ID: <20180426104317.338200ea@redhat.com> (raw)
In-Reply-To: <20180425212245.25999.21181.stgit@john-Precision-Tower-5810>
On Wed, 25 Apr 2018 14:22:45 -0700, John Fastabend wrote:
> --- a/tools/bpf/Makefile
> +++ b/tools/bpf/Makefile
> @@ -76,6 +76,8 @@ $(OUTPUT)bpf_asm: $(OUTPUT)bpf_asm.o $(OUTPUT)bpf_exp.yacc.o $(OUTPUT)bpf_exp.le
> $(QUIET_LINK)$(CC) $(CFLAGS) -o $@ $^
>
> $(OUTPUT)bpf_exp.lex.c: $(OUTPUT)bpf_exp.yacc.c
> +$(OUTPUT)bpf_exp.yacc.o: $(OUTPUT)bpf_exp.yacc.c
> +$(OUTPUT)bpf_exp.lex.o: $(OUTPUT)bpf_exp.lex.c
Looks better than v1, the first dependency is important.
For some reason, I did not need the other two rules.
By the way, make invoked from tools/bpf/ has never really worked, even
before my patchset. This works correctly:
cd tools
make bpf
Jiri
prev parent reply other threads:[~2018-04-26 8:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-25 21:22 [bpf PATCH v2] bpf: fix for lex/yacc build error with gcc-5 John Fastabend
2018-04-25 21:42 ` Daniel Borkmann
2018-04-26 8:43 ` Jiri Benc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180426104317.338200ea@redhat.com \
--to=jbenc@redhat.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).