From: Stephen Hemminger <stephen@networkplumber.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Sridhar Samudrala <sridhar.samudrala@intel.com>,
davem@davemloft.net, netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org,
virtio-dev@lists.oasis-open.org, jesse.brandeburg@intel.com,
alexander.h.duyck@intel.com, kubakici@wp.pl, jasowang@redhat.com,
loseweigh@gmail.com, jiri@resnulli.us, aaron.f.brown@intel.com
Subject: Re: [PATCH net-next v8 4/4] netvsc: refactor notifier/event handling code to use the failover framework
Date: Thu, 26 Apr 2018 15:33:26 -0700 [thread overview]
Message-ID: <20180426153326.16388dfd@xeon-e3> (raw)
In-Reply-To: <20180426052908-mutt-send-email-mst@kernel.org>
On Thu, 26 Apr 2018 05:30:05 +0300
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> On Wed, Apr 25, 2018 at 05:08:37PM -0700, Stephen Hemminger wrote:
> > On Wed, 25 Apr 2018 16:59:28 -0700
> > Sridhar Samudrala <sridhar.samudrala@intel.com> wrote:
> >
> > > Use the registration/notification framework supported by the generic
> > > failover infrastructure.
> > >
> > > Signed-off-by: Sridhar Samudrala <sridhar.samudrala@intel.com>
> >
> > NAK unless you prove this works on legacy distributions and with DPDK 18.05
> > without modification.
>
> It looks like it should work. What kind of proof are you looking for?
>
I tried this with working Ubuntu 17 on WS2016.
It boots if the failover driver is configured in (as module).
But if the configuration has:
$ grep FAILOVER .config
# CONFIG_NET_FAILOVER is not set
CONFIG_MAY_USE_NET_FAILOVER=y
The netvsc driver fails on boot with:
[ 0.826447] hv_vmbus: registering driver hv_netvsc
[ 0.829616] scsi 0:0:0:0: Direct-Access Msft Virtual Disk 1.0 PQ: 0 ANSI: 5
[ 0.836291] input: Microsoft Vmbus HID-compliant Mouse as /devices/0006:045E:0621.0001/input/input1
[ 0.839139] hid-generic 0006:045E:0621.0001: input: <UNKNOWN> HID v0.01 Mouse [Microsoft Vmbus HID-compliant Mouse] on
[ 0.964897] hv_vmbus: probe failed for device 849a776e-8120-4e4a-9a36-7e3d95ac75b3 (-95)
[ 0.968039] hv_netvsc: probe of 849a776e-8120-4e4a-9a36-7e3d95ac75b3 failed with error -95
[ 1.112877] hv_vmbus: probe failed for device 53557f8e-057d-425b-9265-01c0fd7e273e (-95)
[ 1.116064] hv_netvsc: probe of 53557f8e-057d-425b-9265-01c0fd7e273e failed with error -95
The system has two virtual networks. eth0 is on vswitch for management.
eth1 is on vswitch with SR-IOV for performance tests.
You probably need to just put the failover part in net/core and select it.
It is trivial to get an evaluation version of Windows Server 2016 and setup a Linux VM.
Please try it.
next prev parent reply other threads:[~2018-04-26 22:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-25 23:59 [PATCH net-next v8 0/4] Enable virtio_net to act as a standby for a passthru device Sridhar Samudrala
2018-04-25 23:59 ` [PATCH net-next v8 1/4] virtio_net: Introduce VIRTIO_NET_F_STANDBY feature bit Sridhar Samudrala
2018-04-25 23:59 ` [PATCH net-next v8 2/4] net: Introduce generic failover module Sridhar Samudrala
2018-04-27 12:39 ` kbuild test robot
2018-04-28 8:23 ` Dan Carpenter
2018-04-25 23:59 ` [PATCH net-next v8 3/4] virtio_net: Extend virtio to use VF datapath when available Sridhar Samudrala
2018-04-25 23:59 ` [PATCH net-next v8 4/4] netvsc: refactor notifier/event handling code to use the failover framework Sridhar Samudrala
2018-04-26 0:08 ` Stephen Hemminger
2018-04-26 2:30 ` Michael S. Tsirkin
2018-04-26 22:33 ` Stephen Hemminger [this message]
2018-04-27 0:09 ` Michael S. Tsirkin
2018-04-27 0:30 ` Samudrala, Sridhar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180426153326.16388dfd@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=aaron.f.brown@intel.com \
--cc=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=jasowang@redhat.com \
--cc=jesse.brandeburg@intel.com \
--cc=jiri@resnulli.us \
--cc=kubakici@wp.pl \
--cc=loseweigh@gmail.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sridhar.samudrala@intel.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).