From: David Miller <davem@davemloft.net>
To: bjorn.andersson@linaro.org
Cc: clew@codeaurora.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2] net: qrtr: Expose tunneling endpoint to user space
Date: Fri, 27 Apr 2018 10:55:18 -0400 (EDT) [thread overview]
Message-ID: <20180427.105518.55533156322929879.davem@davemloft.net> (raw)
In-Reply-To: <20180423214653.10016-1-bjorn.andersson@linaro.org>
From: Bjorn Andersson <bjorn.andersson@linaro.org>
Date: Mon, 23 Apr 2018 14:46:53 -0700
> + count = min_t(size_t, iov_iter_count(to), skb->len);
> + if (copy_to_iter(skb->data, count, to) != count)
> + count = -EFAULT;
> +
> + kfree_skb(skb);
As noted by Chris, you should be using consume_skb() here.
Thanks.
prev parent reply other threads:[~2018-04-27 14:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-23 21:46 [PATCH v2] net: qrtr: Expose tunneling endpoint to user space Bjorn Andersson
2018-04-26 22:29 ` Chris Lew
2018-04-27 14:55 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180427.105518.55533156322929879.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bjorn.andersson@linaro.org \
--cc=clew@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).