From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH v2] net: qrtr: Expose tunneling endpoint to user space Date: Fri, 27 Apr 2018 10:55:18 -0400 (EDT) Message-ID: <20180427.105518.55533156322929879.davem@davemloft.net> References: <20180423214653.10016-1-bjorn.andersson@linaro.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: clew@codeaurora.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org To: bjorn.andersson@linaro.org Return-path: In-Reply-To: <20180423214653.10016-1-bjorn.andersson@linaro.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Bjorn Andersson Date: Mon, 23 Apr 2018 14:46:53 -0700 > + count = min_t(size_t, iov_iter_count(to), skb->len); > + if (copy_to_iter(skb->data, count, to) != count) > + count = -EFAULT; > + > + kfree_skb(skb); As noted by Chris, you should be using consume_skb() here. Thanks.