From: David Miller <davem@davemloft.net>
To: m.xhonneux@gmail.com
Cc: netdev@vger.kernel.org, dlebrun@google.com, alexei.starovoitov@gmail.com
Subject: Re: [PATCH net-next v2 4/5] ipv6: sr: Add seg6local action End.BPF
Date: Fri, 27 Apr 2018 10:59:19 -0400 (EDT) [thread overview]
Message-ID: <20180427.105919.1774690223194208745.davem@davemloft.net> (raw)
In-Reply-To: <223e33f96b2cb9868a55a686c5d9321162a67ddb.1524591163.git.m.xhonneux@gmail.com>
From: Mathieu Xhonneux <m.xhonneux@gmail.com>
Date: Tue, 24 Apr 2018 18:44:15 +0100
> This patch adds the End.BPF action to the LWT seg6local infrastructure.
> This action works like any other seg6local End action, meaning that an IPv6
> header with SRH is needed, whose DA has to be equal to the SID of the
> action. It will also advance the SRH to the next segment, the BPF program
> does not have to take care of this.
I'd like to see some BPF developers review this change.
But on my side I wonder if, instead of validating the whole thing afterwards,
we should make the helpers accessible by the eBPF program validate the changes
as they are made.
next prev parent reply other threads:[~2018-04-27 14:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 17:44 [PATCH net-next v2 0/5] ipv6: sr: introduce seg6local End.BPF action Mathieu Xhonneux
2018-04-24 17:44 ` [PATCH net-next v2 1/5] ipv6: sr: export function lookup_nexthop Mathieu Xhonneux
2018-04-24 17:44 ` [PATCH net-next v2 2/5] bpf: Add IPv6 Segment Routing helpers Mathieu Xhonneux
2018-04-26 3:54 ` kbuild test robot
2018-04-26 6:41 ` kbuild test robot
2018-04-26 13:45 ` [RFC PATCH] bpf: bpf_push_seg6_encap() can be static kbuild test robot
2018-04-26 13:45 ` [PATCH net-next v2 2/5] bpf: Add IPv6 Segment Routing helpers kbuild test robot
2018-04-24 17:44 ` [PATCH net-next v2 3/5] bpf: Split lwt inout verifier structures Mathieu Xhonneux
2018-04-26 15:29 ` kbuild test robot
2018-04-26 15:29 ` [RFC PATCH] bpf: lwt_out_verifier_ops can be static kbuild test robot
2018-04-24 17:44 ` [PATCH net-next v2 4/5] ipv6: sr: Add seg6local action End.BPF Mathieu Xhonneux
2018-04-27 14:59 ` David Miller [this message]
2018-04-28 0:01 ` Alexei Starovoitov
2018-04-30 20:06 ` Mathieu Xhonneux
2018-04-24 17:44 ` [PATCH net-next v2 5/5] selftests/bpf: test for seg6local End.BPF action Mathieu Xhonneux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180427.105919.1774690223194208745.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexei.starovoitov@gmail.com \
--cc=dlebrun@google.com \
--cc=m.xhonneux@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).