From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next v2 4/5] ipv6: sr: Add seg6local action End.BPF Date: Fri, 27 Apr 2018 10:59:19 -0400 (EDT) Message-ID: <20180427.105919.1774690223194208745.davem@davemloft.net> References: <223e33f96b2cb9868a55a686c5d9321162a67ddb.1524591163.git.m.xhonneux@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, dlebrun@google.com, alexei.starovoitov@gmail.com To: m.xhonneux@gmail.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:52900 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933774AbeD0O7V (ORCPT ); Fri, 27 Apr 2018 10:59:21 -0400 In-Reply-To: <223e33f96b2cb9868a55a686c5d9321162a67ddb.1524591163.git.m.xhonneux@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Mathieu Xhonneux Date: Tue, 24 Apr 2018 18:44:15 +0100 > This patch adds the End.BPF action to the LWT seg6local infrastructure. > This action works like any other seg6local End action, meaning that an IPv6 > header with SRH is needed, whose DA has to be equal to the SID of the > action. It will also advance the SRH to the next segment, the BPF program > does not have to take care of this. I'd like to see some BPF developers review this change. But on my side I wonder if, instead of validating the whole thing afterwards, we should make the helpers accessible by the eBPF program validate the changes as they are made.