From: David Miller <davem@davemloft.net>
To: jakub.kicinski@netronome.com
Cc: netdev@vger.kernel.org, oss-drivers@netronome.com
Subject: Re: [PATCH net] nfp: don't depend on eth_tbl being available
Date: Fri, 27 Apr 2018 11:15:56 -0400 (EDT) [thread overview]
Message-ID: <20180427.111556.1931814913979522341.davem@davemloft.net> (raw)
In-Reply-To: <20180425182108.31363-1-jakub.kicinski@netronome.com>
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Wed, 25 Apr 2018 11:21:08 -0700
> For very very old generation of the management FW Ethernet port
> information table may theoretically not be available. This in
> turn will cause the nfp_port structures to not be allocated.
>
> Make sure we don't crash the kernel when there is no eth_tbl:
>
> RIP: 0010:nfp_net_pci_probe+0xf2/0xb40 [nfp]
> ...
> Call Trace:
> nfp_pci_probe+0x6de/0xab0 [nfp]
> local_pci_probe+0x47/0xa0
> work_for_cpu_fn+0x1a/0x30
> process_one_work+0x1de/0x3e0
>
> Found while working with broken/development version of management FW.
>
> Fixes: a5950182c00e ("nfp: map mac_stats and vf_cfg BARs")
> Fixes: 93da7d9660ee ("nfp: provide nfp_port to of nfp_net_get_mac_addr()")
> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> Reviewed-by: Dirk van der Merwe <dirk.vandermerwe@netronome.com>
Applied, thanks Jakub.
Do you want this queued up for -stable? It seems borderline, at best, to me.
next prev parent reply other threads:[~2018-04-27 15:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-25 18:21 [PATCH net] nfp: don't depend on eth_tbl being available Jakub Kicinski
2018-04-27 15:15 ` David Miller [this message]
2018-04-27 17:38 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180427.111556.1931814913979522341.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox