From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next 0/8] net: Extend availability of PHY statistics
Date: Fri, 27 Apr 2018 12:10:14 -0400 (EDT)
Message-ID: <20180427.121014.155526016617000480.davem@davemloft.net>
References: <20180425191254.3467-1-f.fainelli@gmail.com>
        <20180427.120002.755188410396902589.davem@davemloft.net>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, andrew@lunn.ch,
        vivien.didelot@savoirfairelinux.com, cphealy@gmail.com,
        nikita.yoush@cogentembedded.com
To: f.fainelli@gmail.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:54082 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1758264AbeD0QKP (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 27 Apr 2018 12:10:15 -0400
In-Reply-To: <20180427.120002.755188410396902589.davem@davemloft.net>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: David Miller <davem@davemloft.net>
Date: Fri, 27 Apr 2018 12:00:02 -0400 (EDT)

> From: Florian Fainelli <f.fainelli@gmail.com>
> Date: Wed, 25 Apr 2018 12:12:46 -0700
> 
>> This patch series adds support for retrieving PHY statistics with DSA switches
>> when the CPU port uses a PHY to PHY connection (as opposed to MAC to MAC).
>> To get there a number of things are done:
>> 
>> - first we move the code dealing with PHY statistics outside of net/core/ethtool.c
>>   and create helper functions since the same code will be reused
>> - then we allow network device drivers to provide an ethtool_get_phy_stats callback
>>   when the standard PHY library helpers are not suitable
>> - we update the DSA functions dealing with ethtool operations to get passed a
>>   stringset instead of assuming ETH_SS_STATS like they currently do
>> - then we provide a set of standard helpers within DSA as a framework and add
>>   the plumbing to allow retrieving the PHY statistics of the CPU port(s)
>> - finally plug support for retrieving such PHY statistics with the b53 driver
>  ...
> 
> Series applied, thanks Florian.

Ugh, this breaks the allmodconfig build.

You can't move interfaces to drivers/net/phy/phy.c which are
referenced in core networking like net/core/ethtool.c unless you make
PHYLIB 'bool' only.

net/core/ethtool.o: In function `__ethtool_get_sset_count':
ethtool.c:(.text+0x1cd8): undefined reference to `phy_ethtool_get_sset_count'
net/core/ethtool.o: In function `dev_ethtool':
(.text+0x5407): undefined reference to `phy_ethtool_get_strings'
(.text+0x6869): undefined reference to `phy_ethtool_get_sset_count'
(.text+0x69b3): undefined reference to `phy_ethtool_get_stats'

Please fix this somehow, thanks Florian.