netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: borisp@mellanox.com
Cc: netdev@vger.kernel.org, saeedm@mellanox.com, davejwatson@fb.com,
	ktkhai@virtuozzo.com
Subject: Re: [PATCH V8 net-next 00/14] TLS offload, netdev & MLX5 support
Date: Fri, 27 Apr 2018 13:37:34 -0400 (EDT)	[thread overview]
Message-ID: <20180427.133734.1123443227159288297.davem@davemloft.net> (raw)
In-Reply-To: <20180427.133412.16008743935367755.davem@davemloft.net>

From: David Miller <davem@davemloft.net>
Date: Fri, 27 Apr 2018 13:34:12 -0400 (EDT)

> From: David Miller <davem@davemloft.net>
> Date: Fri, 27 Apr 2018 13:31:47 -0400 (EDT)
> 
>> From: Boris Pismenny <borisp@mellanox.com>
>> Date: Thu, 26 Apr 2018 09:37:08 +0300
>> 
>>> This series adds a generic infrastructure to offload TLS crypto to a
>>> network devices. It enables the kernel TLS socket to skip encryption and
>>> authentication operations on the transmit side of the data path. Leaving
>>> those computationally expensive operations to the NIC.
>>  ...
>> 
>> Series applied.
>> 
>> Assuming no build test issues I will push it out to net-next.
> 
> No dice, I'm reverting.
> 
> net/tls/tls_sw.c: In function ‘tls_set_sw_offload’:
> net/tls/tls_sw.c:1192:22: warning: ‘sw_ctx_rx’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>    sw_ctx_rx->sk_poll = sk->sk_socket->ops->poll;
>    ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~

Also in one of the later patches, there are new files added with empty
lines at the end.  GIT warns about this and I have to fix it up each
and every time.

So if you could fix that too I would appreciate it.

Thanks.

      reply	other threads:[~2018-04-27 17:37 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-26  6:37 [PATCH V8 net-next 00/14] TLS offload, netdev & MLX5 support Boris Pismenny
2018-04-26  6:37 ` [PATCH V8 net-next 01/14] tcp: Add clean acked data hook Boris Pismenny
2018-04-26  6:37 ` [PATCH V8 net-next 02/14] net: Rename and export copy_skb_header Boris Pismenny
2018-04-26  6:37 ` [PATCH V8 net-next 03/14] net: Add Software fallback infrastructure for socket dependent offloads Boris Pismenny
2018-04-26  6:37 ` [PATCH V8 net-next 04/14] net: Add TLS offload netdev ops Boris Pismenny
2018-04-26  6:37 ` [PATCH V8 net-next 05/14] net: Add TLS TX offload features Boris Pismenny
2018-04-26  6:37 ` [PATCH V8 net-next 06/14] net/tls: Split conf to rx + tx Boris Pismenny
2018-04-26  6:37 ` [PATCH V8 net-next 07/14] net/tls: Add generic NIC offload infrastructure Boris Pismenny
2018-04-26  6:37 ` [PATCH V8 net-next 08/14] net/mlx5e: Move defines out of ipsec code Boris Pismenny
2018-04-26  6:37 ` [PATCH V8 net-next 09/14] net/mlx5: Accel, Add TLS tx offload interface Boris Pismenny
2018-04-26  6:37 ` [PATCH V8 net-next 10/14] net/mlx5e: TLS, Add Innova TLS TX support Boris Pismenny
2018-04-26  6:37 ` [PATCH V8 net-next 11/14] net/mlx5e: TLS, Add Innova TLS TX offload data path Boris Pismenny
2018-04-26  6:37 ` [PATCH V8 net-next 12/14] net/mlx5e: TLS, Add error statistics Boris Pismenny
2018-04-26  6:37 ` [PATCH V8 net-next 13/14] MAINTAINERS: Update mlx5 innova driver maintainers Boris Pismenny
2018-04-26  6:37 ` [PATCH V8 net-next 14/14] MAINTAINERS: Update TLS maintainers Boris Pismenny
2018-04-27 17:31 ` [PATCH V8 net-next 00/14] TLS offload, netdev & MLX5 support David Miller
2018-04-27 17:34   ` David Miller
2018-04-27 17:37     ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180427.133734.1123443227159288297.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=borisp@mellanox.com \
    --cc=davejwatson@fb.com \
    --cc=ktkhai@virtuozzo.com \
    --cc=netdev@vger.kernel.org \
    --cc=saeedm@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).