From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] tcp: remove mss check in tcp_select_initial_window() Date: Fri, 27 Apr 2018 14:05:50 -0400 (EDT) Message-ID: <20180427.140550.112235314130624063.davem@davemloft.net> References: <20180426165810.164524-1-tracywwnj@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, ycheng@google.com, edumazet@google.com, soheil@google.com To: weiwan@google.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:55692 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757660AbeD0SFw (ORCPT ); Fri, 27 Apr 2018 14:05:52 -0400 In-Reply-To: <20180426165810.164524-1-tracywwnj@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Wei Wang Date: Thu, 26 Apr 2018 09:58:10 -0700 > From: Wei Wang > > In tcp_select_initial_window(), we only set rcv_wnd to > tcp_default_init_rwnd() if current mss > (1 << wscale). Otherwise, > rcv_wnd is kept at the full receive space of the socket which is a > value way larger than tcp_default_init_rwnd(). > With larger initial rcv_wnd value, receive buffer autotuning logic > takes longer to kick in and increase the receive buffer. > > In a TCP throughput test where receiver has rmem[2] set to 125MB > (wscale is 11), we see the connection gets recvbuf limited at the > beginning of the connection and gets less throughput overall. > > Signed-off-by: Wei Wang > Acked-by: Eric Dumazet > Acked-by: Soheil Hassas Yeganeh > Acked-by: Yuchung Cheng Very nice commit message. Applied.