* [PATCH net-next] selftests: pmtu: Minimum MTU for vti6 is 68
@ 2018-04-26 17:41 Stefano Brivio
2018-04-27 9:33 ` Xin Long
2018-04-27 18:33 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Stefano Brivio @ 2018-04-26 17:41 UTC (permalink / raw)
To: David S . Miller
Cc: Steffen Klassert, Xin Long, Alexey Kodanev, Jarod Wilson,
Sabrina Dubroca, netdev
A vti6 interface can carry IPv4 packets too.
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
---
tools/testing/selftests/net/pmtu.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/net/pmtu.sh b/tools/testing/selftests/net/pmtu.sh
index 1e428781a625..7651fd4d86fe 100755
--- a/tools/testing/selftests/net/pmtu.sh
+++ b/tools/testing/selftests/net/pmtu.sh
@@ -368,7 +368,7 @@ test_pmtu_vti6_link_add_mtu() {
fail=0
- min=1280
+ min=68 # vti6 can carry IPv4 packets too
max=$((65535 - 40))
# Check invalid values first
for v in $((min - 1)) $((max + 1)); do
@@ -384,7 +384,7 @@ test_pmtu_vti6_link_add_mtu() {
done
# Now check valid values
- for v in 1280 1300 $((65535 - 40)); do
+ for v in 68 1280 1300 $((65535 - 40)); do
${ns_a} ip link add vti6_a mtu ${v} type vti6 local ${veth6_a_addr} remote ${veth6_b_addr} key 10
mtu="$(link_get_mtu "${ns_a}" vti6_a)"
${ns_a} ip link del vti6_a
--
2.15.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] selftests: pmtu: Minimum MTU for vti6 is 68
2018-04-26 17:41 [PATCH net-next] selftests: pmtu: Minimum MTU for vti6 is 68 Stefano Brivio
@ 2018-04-27 9:33 ` Xin Long
2018-04-27 18:33 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Xin Long @ 2018-04-27 9:33 UTC (permalink / raw)
To: Stefano Brivio
Cc: David S . Miller, Steffen Klassert, Alexey Kodanev, Jarod Wilson,
Sabrina Dubroca, network dev
On Fri, Apr 27, 2018 at 1:41 AM, Stefano Brivio <sbrivio@redhat.com> wrote:
> A vti6 interface can carry IPv4 packets too.
>
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
> ---
> tools/testing/selftests/net/pmtu.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/net/pmtu.sh b/tools/testing/selftests/net/pmtu.sh
> index 1e428781a625..7651fd4d86fe 100755
> --- a/tools/testing/selftests/net/pmtu.sh
> +++ b/tools/testing/selftests/net/pmtu.sh
> @@ -368,7 +368,7 @@ test_pmtu_vti6_link_add_mtu() {
>
> fail=0
>
> - min=1280
> + min=68 # vti6 can carry IPv4 packets too
> max=$((65535 - 40))
> # Check invalid values first
> for v in $((min - 1)) $((max + 1)); do
> @@ -384,7 +384,7 @@ test_pmtu_vti6_link_add_mtu() {
> done
>
> # Now check valid values
> - for v in 1280 1300 $((65535 - 40)); do
> + for v in 68 1280 1300 $((65535 - 40)); do
> ${ns_a} ip link add vti6_a mtu ${v} type vti6 local ${veth6_a_addr} remote ${veth6_b_addr} key 10
> mtu="$(link_get_mtu "${ns_a}" vti6_a)"
> ${ns_a} ip link del vti6_a
> --
> 2.15.1
>
Reviewed-by: Xin Long <lucien.xin@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] selftests: pmtu: Minimum MTU for vti6 is 68
2018-04-26 17:41 [PATCH net-next] selftests: pmtu: Minimum MTU for vti6 is 68 Stefano Brivio
2018-04-27 9:33 ` Xin Long
@ 2018-04-27 18:33 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-04-27 18:33 UTC (permalink / raw)
To: sbrivio; +Cc: steffen.klassert, lucien.xin, alexey.kodanev, jarod, sd, netdev
From: Stefano Brivio <sbrivio@redhat.com>
Date: Thu, 26 Apr 2018 19:41:02 +0200
> A vti6 interface can carry IPv4 packets too.
>
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-27 18:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-26 17:41 [PATCH net-next] selftests: pmtu: Minimum MTU for vti6 is 68 Stefano Brivio
2018-04-27 9:33 ` Xin Long
2018-04-27 18:33 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).