From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [Cake] [PATCH iproute2-next v5] Add support for cake qdisc Date: Fri, 27 Apr 2018 09:17:02 -0700 Message-ID: <20180427091702.2e91a5dc@xeon-e3> References: <20180427121706.23273-1-toke@toke.dk> <20180427121706.23273-2-toke@toke.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: netdev@vger.kernel.org, cake@lists.bufferbloat.net To: Toke =?UTF-8?B?SMO4aWxhbmQtSsO4cmdlbnNlbg==?= Return-path: Received: from mail-pf0-f172.google.com ([209.85.192.172]:40204 "EHLO mail-pf0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757457AbeD0QRF (ORCPT ); Fri, 27 Apr 2018 12:17:05 -0400 Received: by mail-pf0-f172.google.com with SMTP id f189so1829730pfa.7 for ; Fri, 27 Apr 2018 09:17:04 -0700 (PDT) In-Reply-To: <20180427121706.23273-2-toke@toke.dk> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 27 Apr 2018 14:17:06 +0200 Toke H=C3=B8iland-J=C3=B8rgensen wrote: > + } else if (strcmp(*argv, "datacentre") =3D=3D 0) { > + interval =3D 100; > + target =3D 5; > + } else if (strcmp(*argv, "lan") =3D=3D 0) { > + interval =3D 1000; > + target =3D 50; > + } else if (strcmp(*argv, "metro") =3D=3D 0) { > + interval =3D 10000; > + target =3D 500; > + } else if (strcmp(*argv, "regional") =3D=3D 0) { > + interval =3D 30000; > + target =3D 1500; > + } else if (strcmp(*argv, "internet") =3D=3D 0) { > + interval =3D 100000; > + target =3D 5000; > + } else if (strcmp(*argv, "oceanic") =3D=3D 0) { > + interval =3D 300000; > + target =3D 15000; > + } else if (strcmp(*argv, "satellite") =3D=3D 0) { > + interval =3D 1000000; > + target =3D 50000; > + } else if (strcmp(*argv, "interplanetary") =3D=3D 0) { > + interval =3D 1000000000; > + target =3D 50000000; > + There enough tuning entries of this type, that it would be better to make a table that can be expanded. The code should also only allow one of these options. Use duparg()?