From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH net-next v2 1/6] net: bridge: Publish bridge accessor functions Date: Fri, 27 Apr 2018 09:28:29 -0700 Message-ID: <20180427092829.1673ed74@xeon-e3> References: <20180427151111.22099-1-idosch@mellanox.com> <20180427151111.22099-2-idosch@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org, davem@davemloft.net, jiri@mellanox.com, petrm@mellanox.com, nikolay@cumulusnetworks.com, mlxsw@mellanox.com To: Ido Schimmel Return-path: Received: from mail-pf0-f195.google.com ([209.85.192.195]:39936 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757716AbeD0Q2c (ORCPT ); Fri, 27 Apr 2018 12:28:32 -0400 Received: by mail-pf0-f195.google.com with SMTP id f189so1850976pfa.7 for ; Fri, 27 Apr 2018 09:28:32 -0700 (PDT) In-Reply-To: <20180427151111.22099-2-idosch@mellanox.com> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 27 Apr 2018 18:11:06 +0300 Ido Schimmel wrote: > +int br_vlan_pvid_rtnl(const struct net_device *dev, u16 *p_pvid) > +{ > + struct net_bridge_vlan_group *vg; > + > + ASSERT_RTNL(); > + if (netif_is_bridge_master(dev)) > + vg = br_vlan_group(netdev_priv(dev)); > + else > + return -EINVAL; > + > + *p_pvid = br_get_pvid(vg); > + return 0; > +} > +EXPORT_SYMBOL_GPL(br_vlan_pvid_rtnl); Unless there is a RCU version, no need for _rtnl suffix. Minor style issue, why not make error then go on and return -1 on error. int br_vlan_pvid(const struct net_device *dev) { const struct net_bridge_vlan_group *vg; ASSERT_RTNL(); if (!netif_is_bridge_master(dev)) return -1; vg = br_vlan_group(netdev_priv(dev)); return br_get_pvid(vg); }