netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Michael Wenig <mwenig@vmware.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"eric.dumazet@gmail.com" <eric.dumazet@gmail.com>,
	Shilpi Agarwal <sagarwal@vmware.com>, Boon Ang <bang@vmware.com>,
	Darren Hart <dvhart@vmware.com>,
	Steven Rostedt <srostedt@vmware.com>,
	Abdul Anshad Azeez <aazees@vmware.com>
Subject: Re: Performance regressions in TCP_STREAM tests in Linux 4.15 (and later)
Date: Fri, 27 Apr 2018 23:11:49 -0400	[thread overview]
Message-ID: <20180427231149.119db14c@vmware.local.home> (raw)
In-Reply-To: <BN3PR0501MB1425A7479873B556E84F0AA1B08D0@BN3PR0501MB1425.namprd05.prod.outlook.com>


We'd like this email archived in netdev list, but since netdev is
notorious for blocking outlook email as spam, it didn't go through. So
I'm replying here to help get it into the archives.

Thanks!

-- Steve


On Fri, 27 Apr 2018 23:05:46 +0000
Michael Wenig <mwenig@vmware.com> wrote:

> As part of VMware's performance testing with the Linux 4.15 kernel,
> we identified CPU cost and throughput regressions when comparing to
> the Linux 4.14 kernel. The impacted test cases are mostly TCP_STREAM
> send tests when using small message sizes. The regressions are
> significant (up 3x) and were tracked down to be a side effect of Eric
> Dumazat's RB tree changes that went into the Linux 4.15 kernel.
> Further investigation showed our use of the TCP_NODELAY flag in
> conjunction with Eric's change caused the regressions to show and
> simply disabling TCP_NODELAY brought performance back to normal.
> Eric's change also resulted into significant improvements in our
> TCP_RR test cases.
> 
> 
> 
> Based on these results, our theory is that Eric's change made the
> system overall faster (reduced latency) but as a side effect less
> aggregation is happening (with TCP_NODELAY) and that results in lower
> throughput. Previously even though TCP_NODELAY was set, system was
> slower and we still got some benefit of aggregation. Aggregation
> helps in better efficiency and higher throughput although it can
> increase the latency. If you are seeing a regression in your
> application throughput after this change, using TCP_NODELAY might
> help bring performance back however that might increase latency.
> 
> 
> 
> As such, we are not asking for a fix but simply want to document for
> others what we have found.
> 
> 
> 
> Michael Wenig
> 
> Performance Engineering
> 
> VMware, Inc.
> 

       reply	other threads:[~2018-04-28  3:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <BN3PR0501MB1425A7479873B556E84F0AA1B08D0@BN3PR0501MB1425.namprd05.prod.outlook.com>
2018-04-28  3:11 ` Steven Rostedt [this message]
2018-04-30 16:14   ` Performance regressions in TCP_STREAM tests in Linux 4.15 (and later) Ben Greear
2018-04-30 16:31     ` Steven Rostedt
2018-04-30 16:36     ` Eric Dumazet
2018-04-30 17:47       ` Eric Dumazet
2018-05-02 21:47         ` Michael Wenig
2018-05-02 22:41           ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180427231149.119db14c@vmware.local.home \
    --to=rostedt@goodmis.org \
    --cc=aazees@vmware.com \
    --cc=bang@vmware.com \
    --cc=dvhart@vmware.com \
    --cc=eric.dumazet@gmail.com \
    --cc=mwenig@vmware.com \
    --cc=netdev@vger.kernel.org \
    --cc=sagarwal@vmware.com \
    --cc=srostedt@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).