public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: John Fastabend <john.fastabend@gmail.com>
To: ast@kernel.org, daniel@iogearbox.net
Cc: netdev@vger.kernel.org
Subject: [bpf-next PATCH v2 0/3] Hash support for sock
Date: Fri, 27 Apr 2018 16:24:27 -0700	[thread overview]
Message-ID: <20180427232047.9985.3540.stgit@john-Precision-Tower-5810> (raw)

In the original sockmap implementation we got away with using an
array similar to devmap. However, unlike devmap where an ifindex
has a nice 1:1 function into the map we have found some use cases
with sockets that need to be referenced using longer keys.

This series adds support for a sockhash map reusing as much of
the sockmap code as possible. I made the decision to add sockhash
specific helpers vs trying to generalize the existing helpers
because (a) they have sockmap in the name and (b) the keys are
different types. I prefer to be explicit here rather than play
type games or do something else tricky.

To test this we duplicate all the sockmap testing except swap out
the sockmap with a sockhash.

v2: fix file stats and add v2 tag

---

John Fastabend (3):
      bpf: sockmap, refactor sockmap routines to work with hashmap
      bpf: sockmap, add hash map support
      bpf: selftest additions for SOCKHASH


 include/linux/bpf.h                              |    8 
 include/linux/bpf_types.h                        |    1 
 include/linux/filter.h                           |    3 
 include/net/tcp.h                                |    3 
 include/uapi/linux/bpf.h                         |    6 
 kernel/bpf/core.c                                |    1 
 kernel/bpf/sockmap.c                             |  638 +++++++++++++++++++---
 kernel/bpf/verifier.c                            |   14 
 net/core/filter.c                                |   89 ++-
 tools/bpf/bpftool/map.c                          |    1 
 tools/include/uapi/linux/bpf.h                   |    6 
 tools/testing/selftests/bpf/Makefile             |    3 
 tools/testing/selftests/bpf/test_sockhash_kern.c |    4 
 tools/testing/selftests/bpf/test_sockmap.c       |   27 +
 tools/testing/selftests/bpf/test_sockmap_kern.c  |  340 ------------
 tools/testing/selftests/bpf/test_sockmap_kern.h  |  340 ++++++++++++
 16 files changed, 1034 insertions(+), 450 deletions(-)
 create mode 100644 tools/testing/selftests/bpf/test_sockhash_kern.c
 create mode 100644 tools/testing/selftests/bpf/test_sockmap_kern.h

             reply	other threads:[~2018-04-27 23:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-27 23:24 John Fastabend [this message]
2018-04-27 23:24 ` [bpf-next PATCH v2 1/3] bpf: sockmap, refactor sockmap routines to work with hashmap John Fastabend
2018-04-27 23:24 ` [bpf-next PATCH v2 2/3] bpf: sockmap, add hash map support John Fastabend
2018-04-28  0:09   ` Alexei Starovoitov
2018-04-27 23:24 ` [bpf-next PATCH v2 3/3] bpf: selftest additions for SOCKHASH John Fastabend
2018-04-28  0:10   ` Alexei Starovoitov
2018-04-29  3:43     ` John Fastabend

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180427232047.9985.3540.stgit@john-Precision-Tower-5810 \
    --to=john.fastabend@gmail.com \
    --cc=ast@kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox