From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] net: phy: Fix modular PHYLIB build Date: Sat, 28 Apr 2018 16:51:21 -0400 (EDT) Message-ID: <20180428.165121.2110977415890952990.davem@davemloft.net> References: <20180427194149.16661-1-f.fainelli@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, andrew@lunn.ch To: f.fainelli@gmail.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:41504 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751389AbeD1UvZ (ORCPT ); Sat, 28 Apr 2018 16:51:25 -0400 In-Reply-To: <20180427194149.16661-1-f.fainelli@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Florian Fainelli Date: Fri, 27 Apr 2018 12:41:49 -0700 > After commit c59530d0d5dc ("net: Move PHY statistics code into PHY > library helpers") we made net/core/ethtool.c reference symbols which are > part of the library which can be modular. David introduced a temporary > fix with 1ecd6e8ad996 ("phy: Temporary build fix after phylib changes.") > which would prevent such modularity. > > This is not desireable of course, so instead, just inline the functions > into include/linux/phy.h to keep both options available. > > Fixes: c59530d0d5dc ("net: Move PHY statistics code into PHY library helpers") > Fixes: 1ecd6e8ad996 ("phy: Temporary build fix after phylib changes.") > Signed-off-by: Florian Fainelli Applied, thanks Florian.