From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexei Starovoitov Subject: Re: [bpf-next PATCH v2 3/3] bpf: selftest additions for SOCKHASH Date: Fri, 27 Apr 2018 17:10:40 -0700 Message-ID: <20180428001039.prfomdptje6ywn3k@ast-mbp> References: <20180427232047.9985.3540.stgit@john-Precision-Tower-5810> <20180427232443.9985.48093.stgit@john-Precision-Tower-5810> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: ast@kernel.org, daniel@iogearbox.net, netdev@vger.kernel.org To: John Fastabend Return-path: Received: from mail-pg0-f66.google.com ([74.125.83.66]:47052 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933115AbeD1AKn (ORCPT ); Fri, 27 Apr 2018 20:10:43 -0400 Received: by mail-pg0-f66.google.com with SMTP id z4-v6so2619141pgu.13 for ; Fri, 27 Apr 2018 17:10:43 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180427232443.9985.48093.stgit@john-Precision-Tower-5810> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, Apr 27, 2018 at 04:24:43PM -0700, John Fastabend wrote: > This runs existing SOCKMAP tests with SOCKHASH map type. To do this > we push programs into include file and build two BPF programs. One > for SOCKHASH and one for SOCKMAP. > > We then run the entire test suite with each type. > > Signed-off-by: John Fastabend > --- > tools/testing/selftests/bpf/Makefile | 3 > tools/testing/selftests/bpf/test_sockhash_kern.c | 4 > tools/testing/selftests/bpf/test_sockmap.c | 27 +- > tools/testing/selftests/bpf/test_sockmap_kern.c | 340 ---------------------- > tools/testing/selftests/bpf/test_sockmap_kern.h | 340 ++++++++++++++++++++++ > 5 files changed, 368 insertions(+), 346 deletions(-) > create mode 100644 tools/testing/selftests/bpf/test_sockhash_kern.c > create mode 100644 tools/testing/selftests/bpf/test_sockmap_kern.h Looks like it was mainly a rename of test_sockmap_kern.c into .h but commit doesn't show it as such. Can you redo it with 'git mv' ?