From: Ahmed Abdelsalam <amsalam20@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: dav.lebrun@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [net-next] ipv6: sr: Extract the right key values for "seg6_make_flowlabel"
Date: Sat, 28 Apr 2018 12:20:47 +0200 [thread overview]
Message-ID: <20180428122047.ede46582a46d87139e09eea1@gmail.com> (raw)
In-Reply-To: <20180427.135907.1528151032821602074.davem@davemloft.net>
On Fri, 27 Apr 2018 13:59:07 -0400 (EDT)
David Miller <davem@davemloft.net> wrote:
> From: Ahmed Abdelsalam <amsalam20@gmail.com>
> Date: Thu, 26 Apr 2018 16:11:11 +0200
>
> > @@ -119,6 +119,9 @@ int seg6_do_srh_encap(struct sk_buff *skb, struct ipv6_sr_hdr *osrh, int proto)
> > int hdrlen, tot_len, err;
> > __be32 flowlabel;
> >
> > + inner_hdr = ipv6_hdr(skb);
>
> You have to make this assignment after, not before, the skb_cow_header()
> call. Otherwise this point can be pointing to freed up memory.
Ok!
I fixed and sent you a v2 of the patch.
--
Ahmed Abdelsalam <amsalam20@gmail.com>
prev parent reply other threads:[~2018-04-28 10:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-26 14:11 [net-next] ipv6: sr: Extract the right key values for "seg6_make_flowlabel" Ahmed Abdelsalam
2018-04-27 17:59 ` David Miller
2018-04-28 10:20 ` Ahmed Abdelsalam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180428122047.ede46582a46d87139e09eea1@gmail.com \
--to=amsalam20@gmail.com \
--cc=dav.lebrun@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).