From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ahmed Abdelsalam Subject: Re: [net-next] ipv6: sr: Extract the right key values for "seg6_make_flowlabel" Date: Sat, 28 Apr 2018 12:20:47 +0200 Message-ID: <20180428122047.ede46582a46d87139e09eea1@gmail.com> References: <1524751871-1353-1-git-send-email-amsalam20@gmail.com> <20180427.135907.1528151032821602074.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dav.lebrun@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: David Miller Return-path: In-Reply-To: <20180427.135907.1528151032821602074.davem@davemloft.net> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Fri, 27 Apr 2018 13:59:07 -0400 (EDT) David Miller wrote: > From: Ahmed Abdelsalam > Date: Thu, 26 Apr 2018 16:11:11 +0200 > > > @@ -119,6 +119,9 @@ int seg6_do_srh_encap(struct sk_buff *skb, struct ipv6_sr_hdr *osrh, int proto) > > int hdrlen, tot_len, err; > > __be32 flowlabel; > > > > + inner_hdr = ipv6_hdr(skb); > > You have to make this assignment after, not before, the skb_cow_header() > call. Otherwise this point can be pointing to freed up memory. Ok! I fixed and sent you a v2 of the patch. -- Ahmed Abdelsalam