From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Ricardo Leitner Subject: Re: [PATCH net-next] net: phy: Fix modular PHYLIB build Date: Sat, 28 Apr 2018 17:27:10 -0300 Message-ID: <20180428202710.GA5104@localhost.localdomain> References: <20180427194149.16661-1-f.fainelli@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, davem@davemloft.net, andrew@lunn.ch To: Florian Fainelli Return-path: Received: from mail-qk0-f195.google.com ([209.85.220.195]:40070 "EHLO mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751151AbeD1U1P (ORCPT ); Sat, 28 Apr 2018 16:27:15 -0400 Received: by mail-qk0-f195.google.com with SMTP id h138so3328866qke.7 for ; Sat, 28 Apr 2018 13:27:15 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180427194149.16661-1-f.fainelli@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, Apr 27, 2018 at 12:41:49PM -0700, Florian Fainelli wrote: > After commit c59530d0d5dc ("net: Move PHY statistics code into PHY > library helpers") we made net/core/ethtool.c reference symbols which are > part of the library which can be modular. David introduced a temporary > fix with 1ecd6e8ad996 ("phy: Temporary build fix after phylib changes.") > which would prevent such modularity. > > This is not desireable of course, so instead, just inline the functions > into include/linux/phy.h to keep both options available. > > Fixes: c59530d0d5dc ("net: Move PHY statistics code into PHY library helpers") > Fixes: 1ecd6e8ad996 ("phy: Temporary build fix after phylib changes.") > Signed-off-by: Florian Fainelli Confirmed that this also fixes the build when CONFIG_PHYLIB is off. Thanks.