netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: liuhangbin@gmail.com
Cc: netdev@vger.kernel.org, nikolay@cumulusnetworks.com,
	dvyukov@google.com,
	syzbot+de73361ee4971b6e6f75@syzkaller.appspotmail.com
Subject: Re: [PATCHv2 net] bridge: check iface upper dev when setting master via ioctl
Date: Sun, 29 Apr 2018 21:08:40 -0400 (EDT)	[thread overview]
Message-ID: <20180429.210840.664235916308990188.davem@davemloft.net> (raw)
In-Reply-To: <1524833964-674-1-git-send-email-liuhangbin@gmail.com>

From: Hangbin Liu <liuhangbin@gmail.com>
Date: Fri, 27 Apr 2018 20:59:24 +0800

> When we set a bond slave's master to bridge via ioctl, we only check
> the IFF_BRIDGE_PORT flag. Although we will find the slave's real master
> at netdev_master_upper_dev_link() later, it already does some settings
> and allocates some resources. It would be better to return as early
> as possible.
> 
> v1 -> v2:
> use netdev_master_upper_dev_get() instead of netdev_has_any_upper_dev()
> to check if we have a master, because not all upper devs are masters,
> e.g. vlan device.
> 
> Reported-by: syzbot+de73361ee4971b6e6f75@syzkaller.appspotmail.com
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>

Applied and queued up for -stable, thanks.

      parent reply	other threads:[~2018-04-30  1:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-26 13:56 [PATCH net] bridge: check iface upper dev when setting master via ioctl Hangbin Liu
2018-04-26 14:00 ` Nikolay Aleksandrov
2018-04-26 14:22   ` Nikolay Aleksandrov
2018-04-27  1:31     ` Hangbin Liu
2018-04-27  8:33       ` Nikolay Aleksandrov
2018-04-27 12:59 ` [PATCHv2 " Hangbin Liu
2018-04-28 10:06   ` Nikolay Aleksandrov
2018-04-30  1:08   ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180429.210840.664235916308990188.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dvyukov@google.com \
    --cc=liuhangbin@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    --cc=syzbot+de73361ee4971b6e6f75@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).