From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH V2 net-next 0/6] liquidio: enhanced ethtool --set-channels feature Date: Mon, 30 Apr 2018 09:26:53 -0400 (EDT) Message-ID: <20180430.092653.1474854564188442801.davem@davemloft.net> References: <20180428063204.GA3229@felix-thinkpad.cavium.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, raghu.vatsavayi@cavium.com, derek.chickles@cavium.com, satananda.burla@cavium.com, intiyaz.basha@cavium.com To: felix.manlunas@cavium.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:59646 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752110AbeD3N04 (ORCPT ); Mon, 30 Apr 2018 09:26:56 -0400 In-Reply-To: <20180428063204.GA3229@felix-thinkpad.cavium.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Felix Manlunas Date: Fri, 27 Apr 2018 23:32:04 -0700 > From: Intiyaz Basha > > For the ethtool --set-channels feature, the liquidio driver currently > accepts max combined value as the queue count configured during driver > load time, where max combined count is the total count of input and output > queues. This limitation is applicable only when SR-IOV is enabled, that > is, when VFs are created for PF. If SR-IOV is not enabled, the driver can > configure max supported (64) queues. > > This series of patches are for enhancing driver to accept > max supported queues for ethtool --set-channels. > > Changes in V2: > Only patch #6 was changed to fix these Sparse warnings reported by kbuild > test robot: > lio_ethtool.c:848:5: warning: symbol 'lio_23xx_reconfigure_queue_count' > was not declared. Should it be static? > lio_ethtool.c:877:22: warning: incorrect type in assignment (different > base types) > lio_ethtool.c:878:22: warning: incorrect type in assignment (different > base types) > lio_ethtool.c:879:22: warning: incorrect type in assignment (different > base types) Series applied, thank you.