From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexei Starovoitov Subject: Re: [PATCH bpf-next v2] samples/bpf: fix kprobe attachment issue on x64 Date: Sun, 29 Apr 2018 20:39:27 -0700 Message-ID: <20180430033925.ifghcefbbzhez3wm@ast-mbp> References: <20180430022748.4093322-1-yhs@fb.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: ast@fb.com, daniel@iogearbox.net, netdev@vger.kernel.org, kernel-team@fb.com To: Yonghong Song Return-path: Received: from mail-pf0-f194.google.com ([209.85.192.194]:45229 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751242AbeD3Djb (ORCPT ); Sun, 29 Apr 2018 23:39:31 -0400 Received: by mail-pf0-f194.google.com with SMTP id c10so5696958pfi.12 for ; Sun, 29 Apr 2018 20:39:31 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180430022748.4093322-1-yhs@fb.com> Sender: netdev-owner@vger.kernel.org List-ID: On Sun, Apr 29, 2018 at 07:27:48PM -0700, Yonghong Song wrote: > Commit d5a00528b58c ("syscalls/core, syscalls/x86: Rename > struct pt_regs-based sys_*() to __x64_sys_*()") renamed a lot > of syscall function sys_*() to __x64_sys_*(). > This caused several kprobe based samples/bpf tests failing. > > This patch fixed the problem in bpf_load.c. > For x86_64 architecture, function name __x64_sys_*() will be > first used for kprobe event creation. If the creation is successful, > it will be used. Otherwise, function name sys_*() will be used > for kprobe event creation. > > Fixes: d5a00528b58c ("syscalls/core, syscalls/x86: Rename struct pt_regs-based sys_*() to __x64_sys_*()") > Signed-off-by: Yonghong Song Applied, Thanks Yonghong.