From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: rsi_91x: fix structurally dead code Date: Mon, 30 Apr 2018 10:33:15 +0000 (UTC) Message-ID: <20180430103315.35F26606AC@smtp.codeaurora.org> References: <20180426130138.GA440@embeddedor.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: Prameela Rani Garnepudi , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" To: "Gustavo A. R. Silva" Return-path: In-Reply-To: <20180426130138.GA440@embeddedor.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org "Gustavo A. R. Silva" wrote: > Function rsi_hal_key_config returns before reaching code at line > 922 if (status), hence this code is structurally dead. > > Fix this by storing the value returned by rsi_hal_load_key > into _status_ for its further evaluation and use. > > Addresses-Coverity-ID: 1468409 ("Structurally dead code") > Fixes: 4fd6c4762f37 ("rsi: roaming enhancements") > Signed-off-by: Gustavo A. R. Silva Patch applied to wireless-drivers-next.git, thanks. e1fd7ceec194 rsi_91x: fix structurally dead code -- https://patchwork.kernel.org/patch/10365997/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches