From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: rsi_91x: fix uninitialized variable Date: Mon, 30 Apr 2018 10:34:24 +0000 (UTC) Message-ID: <20180430103424.D492960807@smtp.codeaurora.org> References: <20180426131324.GA982@embeddedor.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: Amitkumar Karwar , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" To: "Gustavo A. R. Silva" Return-path: In-Reply-To: <20180426131324.GA982@embeddedor.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org "Gustavo A. R. Silva" wrote: > There is a potential execution path in which variable ret is returned > without being properly initialized previously. > > Fix this by storing the value returned by function > rsi_usb_master_reg_write into _ret_. > > Addresses-Coverity-ID: 1468407 ("Uninitialized scalar variable") > Fixes: 16d3bb7b2f37 ("rsi: disable fw watchdog timer during reset") > Signed-off-by: Gustavo A. R. Silva Patch applied to wireless-drivers-next.git, thanks. 48c6b5c9c118 rsi_91x: fix uninitialized variable -- https://patchwork.kernel.org/patch/10365985/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches