From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next 0/2] sctp: unify sctp_make_op_error_fixed and
 sctp_make_op_error_space
Date: Tue, 01 May 2018 12:13:53 -0400 (EDT)
Message-ID: <20180501.121353.1918662858023133319.davem@davemloft.net>
References: <cover.1525017179.git.marcelo.leitner@gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org,
        vyasevich@gmail.com, nhorman@tuxdriver.com, lucien.xin@gmail.com
To: marcelo.leitner@gmail.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:46766 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751071AbeEAQN5 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 1 May 2018 12:13:57 -0400
In-Reply-To: <cover.1525017179.git.marcelo.leitner@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Date: Sun, 29 Apr 2018 12:56:30 -0300

> These two variants are very close to each other and can be merged
> to avoid code duplication. That's what this patchset does.
> 
> First, we allow sctp_init_cause to return errors, which then allow us to
> add sctp_make_op_error_limited that handles both situations.

Series applied.

But generally, there are a lot of smtp_init_cause() call sites with non-zero
payload length that should start checking the return value now.