* [PATCH] vhost: make msg padding explicit @ 2018-04-27 16:02 Michael S. Tsirkin 2018-04-30 1:34 ` David Miller 2018-05-01 15:28 ` David Miller 0 siblings, 2 replies; 10+ messages in thread From: Michael S. Tsirkin @ 2018-04-27 16:02 UTC (permalink / raw) To: linux-kernel; +Cc: Kevin Easton, Jason Wang, kvm, virtualization, netdev There's a 32 bit hole just after type. It's best to give it a name, this way compiler is forced to initialize it with rest of the structure. Reported-by: Kevin Easton <kevin@guarana.org> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- include/uapi/linux/vhost.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/linux/vhost.h b/include/uapi/linux/vhost.h index c51f8e5..5a8ad06 100644 --- a/include/uapi/linux/vhost.h +++ b/include/uapi/linux/vhost.h @@ -68,6 +68,7 @@ struct vhost_iotlb_msg { struct vhost_msg { int type; + int padding0; union { struct vhost_iotlb_msg iotlb; __u8 padding[64]; -- MST ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] vhost: make msg padding explicit 2018-04-27 16:02 [PATCH] vhost: make msg padding explicit Michael S. Tsirkin @ 2018-04-30 1:34 ` David Miller 2018-05-01 15:28 ` David Miller 1 sibling, 0 replies; 10+ messages in thread From: David Miller @ 2018-04-30 1:34 UTC (permalink / raw) To: mst; +Cc: linux-kernel, kevin, jasowang, kvm, virtualization, netdev From: "Michael S. Tsirkin" <mst@redhat.com> Date: Fri, 27 Apr 2018 19:02:05 +0300 > There's a 32 bit hole just after type. It's best to > give it a name, this way compiler is forced to initialize > it with rest of the structure. > > Reported-by: Kevin Easton <kevin@guarana.org> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Who applied this, me? :-) ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] vhost: make msg padding explicit 2018-04-27 16:02 [PATCH] vhost: make msg padding explicit Michael S. Tsirkin 2018-04-30 1:34 ` David Miller @ 2018-05-01 15:28 ` David Miller 2018-05-01 17:19 ` Michael S. Tsirkin 1 sibling, 1 reply; 10+ messages in thread From: David Miller @ 2018-05-01 15:28 UTC (permalink / raw) To: mst; +Cc: linux-kernel, kevin, jasowang, kvm, virtualization, netdev From: "Michael S. Tsirkin" <mst@redhat.com> Date: Fri, 27 Apr 2018 19:02:05 +0300 > There's a 32 bit hole just after type. It's best to > give it a name, this way compiler is forced to initialize > it with rest of the structure. > > Reported-by: Kevin Easton <kevin@guarana.org> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Michael, will you be sending this directly to Linus or would you like me to apply it to net or net-next? Thanks. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] vhost: make msg padding explicit 2018-05-01 15:28 ` David Miller @ 2018-05-01 17:19 ` Michael S. Tsirkin 2018-05-01 18:05 ` David Miller 0 siblings, 1 reply; 10+ messages in thread From: Michael S. Tsirkin @ 2018-05-01 17:19 UTC (permalink / raw) To: David Miller; +Cc: linux-kernel, kevin, jasowang, kvm, virtualization, netdev On Tue, May 01, 2018 at 11:28:22AM -0400, David Miller wrote: > From: "Michael S. Tsirkin" <mst@redhat.com> > Date: Fri, 27 Apr 2018 19:02:05 +0300 > > > There's a 32 bit hole just after type. It's best to > > give it a name, this way compiler is forced to initialize > > it with rest of the structure. > > > > Reported-by: Kevin Easton <kevin@guarana.org> > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > > Michael, will you be sending this directly to Linus or would you like > me to apply it to net or net-next? > > Thanks. I'd prefer you to apply it for net and cc stable if possible. Thanks! -- MST ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] vhost: make msg padding explicit 2018-05-01 17:19 ` Michael S. Tsirkin @ 2018-05-01 18:05 ` David Miller 2018-05-02 6:28 ` Kevin Easton 0 siblings, 1 reply; 10+ messages in thread From: David Miller @ 2018-05-01 18:05 UTC (permalink / raw) To: mst; +Cc: linux-kernel, kevin, jasowang, kvm, virtualization, netdev From: "Michael S. Tsirkin" <mst@redhat.com> Date: Tue, 1 May 2018 20:19:19 +0300 > On Tue, May 01, 2018 at 11:28:22AM -0400, David Miller wrote: >> From: "Michael S. Tsirkin" <mst@redhat.com> >> Date: Fri, 27 Apr 2018 19:02:05 +0300 >> >> > There's a 32 bit hole just after type. It's best to >> > give it a name, this way compiler is forced to initialize >> > it with rest of the structure. >> > >> > Reported-by: Kevin Easton <kevin@guarana.org> >> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> >> >> Michael, will you be sending this directly to Linus or would you like >> me to apply it to net or net-next? >> >> Thanks. > > I'd prefer you to apply it for net and cc stable if possible. Ok, applied, and added to my -stable submission queue. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] vhost: make msg padding explicit 2018-05-01 18:05 ` David Miller @ 2018-05-02 6:28 ` Kevin Easton 2018-05-02 13:36 ` Michael S. Tsirkin 0 siblings, 1 reply; 10+ messages in thread From: Kevin Easton @ 2018-05-02 6:28 UTC (permalink / raw) To: David Miller; +Cc: mst, linux-kernel, jasowang, kvm, virtualization, netdev On Tue, May 01, 2018 at 02:05:51PM -0400, David Miller wrote: > From: "Michael S. Tsirkin" <mst@redhat.com> > Date: Tue, 1 May 2018 20:19:19 +0300 > > > On Tue, May 01, 2018 at 11:28:22AM -0400, David Miller wrote: > >> From: "Michael S. Tsirkin" <mst@redhat.com> > >> Date: Fri, 27 Apr 2018 19:02:05 +0300 > >> > >> > There's a 32 bit hole just after type. It's best to > >> > give it a name, this way compiler is forced to initialize > >> > it with rest of the structure. > >> > > >> > Reported-by: Kevin Easton <kevin@guarana.org> > >> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > >> > >> Michael, will you be sending this directly to Linus or would you like > >> me to apply it to net or net-next? > >> > >> Thanks. > > > > I'd prefer you to apply it for net and cc stable if possible. > > Ok, applied, and added to my -stable submission queue. Hold on, this patch changes the layout for i386 (where there is no padding at all). And it's part of UAPI. - Kevin > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] vhost: make msg padding explicit 2018-05-02 6:28 ` Kevin Easton @ 2018-05-02 13:36 ` Michael S. Tsirkin 2018-05-02 14:04 ` David Miller 0 siblings, 1 reply; 10+ messages in thread From: Michael S. Tsirkin @ 2018-05-02 13:36 UTC (permalink / raw) To: Kevin Easton Cc: David Miller, linux-kernel, jasowang, kvm, virtualization, netdev On Wed, May 02, 2018 at 02:28:09AM -0400, Kevin Easton wrote: > On Tue, May 01, 2018 at 02:05:51PM -0400, David Miller wrote: > > From: "Michael S. Tsirkin" <mst@redhat.com> > > Date: Tue, 1 May 2018 20:19:19 +0300 > > > > > On Tue, May 01, 2018 at 11:28:22AM -0400, David Miller wrote: > > >> From: "Michael S. Tsirkin" <mst@redhat.com> > > >> Date: Fri, 27 Apr 2018 19:02:05 +0300 > > >> > > >> > There's a 32 bit hole just after type. It's best to > > >> > give it a name, this way compiler is forced to initialize > > >> > it with rest of the structure. > > >> > > > >> > Reported-by: Kevin Easton <kevin@guarana.org> > > >> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > > >> > > >> Michael, will you be sending this directly to Linus or would you like > > >> me to apply it to net or net-next? > > >> > > >> Thanks. > > > > > > I'd prefer you to apply it for net and cc stable if possible. > > > > Ok, applied, and added to my -stable submission queue. > > Hold on, this patch changes the layout for i386 (where there is > no padding at all). And it's part of UAPI. > > - Kevin > > > Ouch. True - and in particular the 32 bit ABI on 64 bit kernels doesn't work at all. Hmm. It's relatively new and maybe there aren't any 32 bit users yet. Thoughts? -- MST ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] vhost: make msg padding explicit 2018-05-02 13:36 ` Michael S. Tsirkin @ 2018-05-02 14:04 ` David Miller 2018-05-02 14:19 ` Michael S. Tsirkin 0 siblings, 1 reply; 10+ messages in thread From: David Miller @ 2018-05-02 14:04 UTC (permalink / raw) To: mst; +Cc: kevin, kvm, netdev, linux-kernel, virtualization From: "Michael S. Tsirkin" <mst@redhat.com> Date: Wed, 2 May 2018 16:36:37 +0300 > Ouch. True - and in particular the 32 bit ABI on 64 bit kernels doesn't > work at all. Hmm. It's relatively new and maybe there aren't any 32 bit > users yet. Thoughts? If it's been in a released kernel version, we really aren't at liberty to play "maybe nobody uses this" UAPI changing games. Please send me a revert. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] vhost: make msg padding explicit 2018-05-02 14:04 ` David Miller @ 2018-05-02 14:19 ` Michael S. Tsirkin 2018-05-02 14:40 ` Kevin Easton 0 siblings, 1 reply; 10+ messages in thread From: Michael S. Tsirkin @ 2018-05-02 14:19 UTC (permalink / raw) To: David Miller; +Cc: kevin, kvm, netdev, linux-kernel, virtualization On Wed, May 02, 2018 at 10:04:46AM -0400, David Miller wrote: > From: "Michael S. Tsirkin" <mst@redhat.com> > Date: Wed, 2 May 2018 16:36:37 +0300 > > > Ouch. True - and in particular the 32 bit ABI on 64 bit kernels doesn't > > work at all. Hmm. It's relatively new and maybe there aren't any 32 bit > > users yet. Thoughts? > > If it's been in a released kernel version, we really aren't at liberty > to play "maybe nobody uses this" UAPI changing games. > > Please send me a revert. Sent. Looking at compat mess now. -- MST ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] vhost: make msg padding explicit 2018-05-02 14:19 ` Michael S. Tsirkin @ 2018-05-02 14:40 ` Kevin Easton 0 siblings, 0 replies; 10+ messages in thread From: Kevin Easton @ 2018-05-02 14:40 UTC (permalink / raw) To: Michael S. Tsirkin Cc: David Miller, linux-kernel, jasowang, kvm, virtualization, netdev On Wed, May 02, 2018 at 05:19:27PM +0300, Michael S. Tsirkin wrote: > On Wed, May 02, 2018 at 10:04:46AM -0400, David Miller wrote: > > From: "Michael S. Tsirkin" <mst@redhat.com> > > Date: Wed, 2 May 2018 16:36:37 +0300 > > > > > Ouch. True - and in particular the 32 bit ABI on 64 bit kernels doesn't > > > work at all. Hmm. It's relatively new and maybe there aren't any 32 bit > > > users yet. Thoughts? > > > > If it's been in a released kernel version, we really aren't at liberty > > to play "maybe nobody uses this" UAPI changing games. > > > > Please send me a revert. > > Sent. Looking at compat mess now. Just naming the padding field isn't sufficient anyway, there also needs to be code in vhost_new_msg() to initialise it using the name. - Kevin ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2018-05-02 14:40 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-04-27 16:02 [PATCH] vhost: make msg padding explicit Michael S. Tsirkin 2018-04-30 1:34 ` David Miller 2018-05-01 15:28 ` David Miller 2018-05-01 17:19 ` Michael S. Tsirkin 2018-05-01 18:05 ` David Miller 2018-05-02 6:28 ` Kevin Easton 2018-05-02 13:36 ` Michael S. Tsirkin 2018-05-02 14:04 ` David Miller 2018-05-02 14:19 ` Michael S. Tsirkin 2018-05-02 14:40 ` Kevin Easton
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).