netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: paulb@mellanox.com
Cc: jiri@mellanox.com, xiyou.wangcong@gmail.com, jhs@mojatatu.com,
	netdev@vger.kernel.org, kliteyn@mellanox.com, roid@mellanox.com,
	shahark@mellanox.com, markb@mellanox.com, ogerlitz@mellanox.com
Subject: Re: [PATCH net-next V2] cls_flower: Support multiple masks per priority
Date: Tue, 01 May 2018 14:14:37 -0400 (EDT)	[thread overview]
Message-ID: <20180501.141437.1748996416481929177.davem@davemloft.net> (raw)
In-Reply-To: <1525087710-17495-1-git-send-email-paulb@mellanox.com>

From: Paul Blakey <paulb@mellanox.com>
Date: Mon, 30 Apr 2018 14:28:30 +0300

> Currently flower doesn't support inserting filters with different masks
> on a single priority, even if the actual flows (key + mask) inserted
> aren't overlapping, as with the use case of offloading openvswitch
> datapath flows. Instead one must go up one level, and assign different
> priorities for each mask, which will create a different flower
> instances.
> 
> This patch opens flower to support more than one mask per priority,
> and a single flower instance. It does so by adding another hash table
> on top of the existing one which will store the different masks,
> and the filters that share it.
> 
> The user is left with the responsibility of ensuring non overlapping
> flows, otherwise precedence is not guaranteed.
> 
> Signed-off-by: Paul Blakey <paulb@mellanox.com>
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
> ---
> 
> Changes:
> V1 -> V2: in fl_init, removed unnessecry err variable, just return direct result instead.
>           in fl_mask_range, removed extra new line.
>           commit msg, spelling.

Applied, thanks.

      reply	other threads:[~2018-05-01 18:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-30 11:28 [PATCH net-next V2] cls_flower: Support multiple masks per priority Paul Blakey
2018-05-01 18:14 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180501.141437.1748996416481929177.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=jhs@mojatatu.com \
    --cc=jiri@mellanox.com \
    --cc=kliteyn@mellanox.com \
    --cc=markb@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=ogerlitz@mellanox.com \
    --cc=paulb@mellanox.com \
    --cc=roid@mellanox.com \
    --cc=shahark@mellanox.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).