From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next V2] cls_flower: Support multiple masks per priority Date: Tue, 01 May 2018 14:14:37 -0400 (EDT) Message-ID: <20180501.141437.1748996416481929177.davem@davemloft.net> References: <1525087710-17495-1-git-send-email-paulb@mellanox.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: jiri@mellanox.com, xiyou.wangcong@gmail.com, jhs@mojatatu.com, netdev@vger.kernel.org, kliteyn@mellanox.com, roid@mellanox.com, shahark@mellanox.com, markb@mellanox.com, ogerlitz@mellanox.com To: paulb@mellanox.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:48358 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756236AbeEASOk (ORCPT ); Tue, 1 May 2018 14:14:40 -0400 In-Reply-To: <1525087710-17495-1-git-send-email-paulb@mellanox.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Paul Blakey Date: Mon, 30 Apr 2018 14:28:30 +0300 > Currently flower doesn't support inserting filters with different masks > on a single priority, even if the actual flows (key + mask) inserted > aren't overlapping, as with the use case of offloading openvswitch > datapath flows. Instead one must go up one level, and assign different > priorities for each mask, which will create a different flower > instances. > > This patch opens flower to support more than one mask per priority, > and a single flower instance. It does so by adding another hash table > on top of the existing one which will store the different masks, > and the filters that share it. > > The user is left with the responsibility of ensuring non overlapping > flows, otherwise precedence is not guaranteed. > > Signed-off-by: Paul Blakey > Signed-off-by: Jiri Pirko > --- > > Changes: > V1 -> V2: in fl_init, removed unnessecry err variable, just return direct result instead. > in fl_mask_range, removed extra new line. > commit msg, spelling. Applied, thanks.